diff options
author | Neels Hofmeyr <nhofmeyr@sysmocom.de> | 2024-03-18 08:07:55 +0100 |
---|---|---|
committer | Neels Hofmeyr <nhofmeyr@sysmocom.de> | 2024-03-19 04:43:21 +0100 |
commit | ae1ba71c3e5976c52bc928b1be59b6b560581b69 (patch) | |
tree | 2a8ddfcf58a2c79857c8ce189fd1a257519786cd | |
parent | f1f869e623578a6bf694d58b5e266969ef13b18e (diff) |
HACK: make Node-ID non-mandatory to accomodate some non-standard serverneels/tweaks
eUPF omits the Node-ID when the Session Establishment Response reports a
failure.
This patch is bad because all current callers need to adjust, and make
sure to set the newly added node_id_present flag to true.
See also https://github.com/edgecomllc/eupf/issues/539
-rw-r--r-- | src/libosmo-pfcp/gen__pfcp_ies_auto.c | 2 | ||||
-rw-r--r-- | tests/libosmo-pfcp/pfcp_test.c | 1 |
2 files changed, 2 insertions, 1 deletions
diff --git a/src/libosmo-pfcp/gen__pfcp_ies_auto.c b/src/libosmo-pfcp/gen__pfcp_ies_auto.c index 5649fe3..f705417 100644 --- a/src/libosmo-pfcp/gen__pfcp_ies_auto.c +++ b/src/libosmo-pfcp/gen__pfcp_ies_auto.c @@ -293,7 +293,7 @@ static const struct osmo_gtlv_gen_ie_o ies_in_msg_session_est_req[] = { }; static const struct osmo_gtlv_gen_ie_o ies_in_msg_session_est_resp[] = { - M(ALL_FROM_NAME, "node_id"), + O(ALL_FROM_NAME, "node_id"), Ms(cause), Os(offending_ie), O(f_seid, "up_f_seid"), diff --git a/tests/libosmo-pfcp/pfcp_test.c b/tests/libosmo-pfcp/pfcp_test.c index 801932c..408d263 100644 --- a/tests/libosmo-pfcp/pfcp_test.c +++ b/tests/libosmo-pfcp/pfcp_test.c @@ -273,6 +273,7 @@ struct osmo_pfcp_msg tests[] = { .seid = 0x0123456789abcdef, }, .ies.session_est_resp = { + .node_id_present = true, .node_id = { .type = OSMO_PFCP_NODE_ID_T_IPV4, .ip.u.sin = { |