From 5848845c34425aa21f4e136049f95b37214df841 Mon Sep 17 00:00:00 2001 From: Dario Lombardo Date: Tue, 5 Jul 2016 23:35:11 +0200 Subject: Qt: remove unneeded constructors. There is no need to have an empty private constructor if an explicit one is already present. The former private constructor didn't initialize the private members causing many CIDs from coverity. Change-Id: I8ba98d2b9fc32a867fdcf3421df7946b90bd7b09 Reviewed-on: https://code.wireshark.org/review/16311 Petri-Dish: Dario Lombardo Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte --- ui/qt/lbm_lbtrm_transport_dialog.cpp | 4 ---- ui/qt/lbm_lbtru_transport_dialog.cpp | 5 ----- 2 files changed, 9 deletions(-) diff --git a/ui/qt/lbm_lbtrm_transport_dialog.cpp b/ui/qt/lbm_lbtrm_transport_dialog.cpp index b232f927ed..5b2a17427e 100644 --- a/ui/qt/lbm_lbtrm_transport_dialog.cpp +++ b/ui/qt/lbm_lbtrm_transport_dialog.cpp @@ -160,7 +160,6 @@ class LBMLBTRMFrameEntry : public QTreeWidgetItem guint32 getFrame(void) { return (m_frame); } private: - LBMLBTRMFrameEntry(void) { } guint32 m_frame; }; @@ -385,7 +384,6 @@ class LBMLBTRMSourceTransportEntry : public QTreeWidgetItem QString m_transport; private: - LBMLBTRMSourceTransportEntry(void) { } void fillItem(void); guint64 m_data_frames; guint64 m_data_bytes; @@ -623,7 +621,6 @@ class LBMLBTRMSourceEntry : public QTreeWidgetItem void processPacket(const packet_info * pinfo, const lbm_lbtrm_tap_info_t * tap_info); private: - LBMLBTRMSourceEntry(void) { } void fillItem(void); QString m_address; QString m_transport; @@ -796,7 +793,6 @@ class LBMLBTRMReceiverTransportEntry : public QTreeWidgetItem void processPacket(const packet_info * pinfo, const lbm_lbtrm_tap_info_t * tap_info); private: - LBMLBTRMReceiverTransportEntry(void) { } void fillItem(void); QString m_transport; guint64 m_nak_frames; diff --git a/ui/qt/lbm_lbtru_transport_dialog.cpp b/ui/qt/lbm_lbtru_transport_dialog.cpp index a787b12808..52fff9ae96 100644 --- a/ui/qt/lbm_lbtru_transport_dialog.cpp +++ b/ui/qt/lbm_lbtru_transport_dialog.cpp @@ -178,7 +178,6 @@ class LBMLBTRUFrameEntry : public QTreeWidgetItem guint32 getFrame(void) { return (m_frame); } private: - LBMLBTRUFrameEntry(void) { } guint32 m_frame; }; @@ -534,7 +533,6 @@ class LBMLBTRUSourceTransportEntry : public QTreeWidgetItem QString m_transport; private: - LBMLBTRUSourceTransportEntry(void) { } void fillItem(void); guint64 m_data_frames; guint64 m_data_bytes; @@ -812,7 +810,6 @@ class LBMLBTRUSourceEntry : public QTreeWidgetItem void processPacket(const packet_info * pinfo, const lbm_lbtru_tap_info_t * tap_info); private: - LBMLBTRUSourceEntry(void) { } void fillItem(void); QString m_address; QString m_transport; @@ -1001,7 +998,6 @@ class LBMLBTRUReceiverTransportEntry : public QTreeWidgetItem void processPacket(const packet_info * pinfo, const lbm_lbtru_tap_info_t * tap_info); private: - LBMLBTRUReceiverTransportEntry(void) { } void fillItem(void); QString m_transport; guint64 m_nak_frames; @@ -1207,7 +1203,6 @@ class LBMLBTRUReceiverEntry : public QTreeWidgetItem void processPacket(const packet_info * pinfo, const lbm_lbtru_tap_info_t * tap_info); private: - LBMLBTRUReceiverEntry(void) { } void fillItem(void); QString m_address; QString m_transport; -- cgit v1.2.3