smalltalk
/
osmo-st-gsm
Archived
1
0
Fork 0
Code Releases Activity

gsm: Deal with CC Capability being two byte instead of one 

This is a spec violation... no idea how to deal properly with this
one right now.
This commit is contained in:
Holger Hans Peter Freyther 2011-10-07 16:43:51 +02:00
parent 5e71a9cb7e
commit c115abccca
2 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
GSM48.st
View File

@ -820,9 +820,13 @@ GSM48DataHolder subclass: GSMCCCapabilities [
<category: 'OsmoGSM'>
<comment: '10.5.4.5a'>
"TODO: the length is fixed to three"
GSMCCCapabilities class >> elementId [ ^ 16r15 ]
GSMCCCapabilities class >> validSizes [ ^ 1 to: 1 ]
GSMCCCapabilities class >> validSizes [ ^ 1 to: 2 ]
"TODO: How to handle things that are specified like this but different in
reality? The code should be able to be uses as both validation and real world
parsing code."
GSMCCCapabilities class >> strictlyValidSizes [ ^ 1 to: 1 ]
]
GSM48DataHolder subclass: GSMConnectedNumber [

7
Tests.st
View File

@ -492,6 +492,13 @@ TestCase subclass: TestMessages [
msg := MSGParser parse: inp.
self assert: msg toMessage asByteArray = inp.
]
testCCSetupWithCC [
| inp msg |
inp := #(16r01 16r0A 16r4B 16r04 16r02 16r02 16r04 16r02 16r42 16rFE 16r0F 16r23 16r00 16r21 16r57 16r05 16r08 16r00 16r72 16rF4 16r80 16r10 16r1C 16r9C 16r41 16r17 16r14 16r03 16r45 16r04 16r06 16r60 16r04 16r02 16r00 16r05 16r81 16r5E 16r04 16r80 16r4A 16r55 16rF1 16r15 16r02 16r11 16r01 16r00) asByteArray.
msg := MSGParser parse: inp.
self assert: msg toMessage asByteArray = inp.
]
]
Object subclass: DummyConnection [