From b8dc47cf22e5f8d9f3fb037ed98d0ecc01c3064e Mon Sep 17 00:00:00 2001 From: Harald Welte Date: Wed, 22 May 2019 21:52:25 +0200 Subject: sap_fsm: Fix what appears to be a missing pointer dereference MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit sap_fsm.c: In function ‘sap_negotiate_msg_size’: sap_fsm.c:103:15: warning: passing argument 1 of ‘__bswap_16’ makes integer from pointer without a cast [-Wint-conversion] size = ntohs((uint16_t *) param->value); ^~~~~~~~~~~~~~~~~~~~~~~~~ Change-Id: Ie58af6162c67ae377809b42daa897ca3f3d72af1 --- src/host/layer23/src/common/sap_fsm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/host/layer23/src/common/sap_fsm.c b/src/host/layer23/src/common/sap_fsm.c index f07488f0..742e200e 100644 --- a/src/host/layer23/src/common/sap_fsm.c +++ b/src/host/layer23/src/common/sap_fsm.c @@ -100,7 +100,7 @@ static void sap_negotiate_msg_size(struct osmosap_entity *sap, } /* Parse MaxMsgSize suggested by server */ - size = ntohs((uint16_t *) param->value); + size = ntohs(*(uint16_t *) param->value); if (size > SAP_MAX_MSG_SIZE) { cause = "suggested MaxMsgSize is too big for us"; goto error; -- cgit v1.2.3