From 8d093f5e291b847c326e02cbbe660a7ad5fc11e1 Mon Sep 17 00:00:00 2001 From: Vadim Yanitskiy Date: Sat, 12 May 2018 03:05:50 +0700 Subject: common/l1ctl.c: fix: drop TCH frame length / magic check It was assumed that only FR frames (with magic 0xd) can be carried by the L1CTL_TRAFFIC messages, but there are also EFR, HR, and AMR frames, and dropping them is not a good idea. Change-Id: I4b7b85d94f11deb7525b63f3549a182c6e76da08 --- src/host/layer23/src/common/l1ctl.c | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/src/host/layer23/src/common/l1ctl.c b/src/host/layer23/src/common/l1ctl.c index 4291d81b..659bfcbe 100644 --- a/src/host/layer23/src/common/l1ctl.c +++ b/src/host/layer23/src/common/l1ctl.c @@ -826,20 +826,6 @@ int l1ctl_tx_traffic_req(struct osmocom_ms *ms, struct msgb *msg, DEBUGP(DL1C, "TRAFFIC REQ (len=%zu): %s\n", frame_len, osmo_hexdump(frame, frame_len)); - if (frame_len != 33) { - LOGP(DL1C, LOGL_ERROR, "Traffic Request has incorrect length " - "(%u != 33)\n", frame_len); - msgb_free(msg); - return -EINVAL; - } - - if ((frame[0] >> 4) != 0xd) { - LOGP(DL1C, LOGL_ERROR, "Traffic Request has incorrect magic " - "(%u != 0xd)\n", frame[0] >> 4); - msgb_free(msg); - return -EINVAL; - } - // printf("TX %s\n", osmo_hexdump(frame, frame_len)); /* prepend uplink info header */ -- cgit v1.2.3