summaryrefslogtreecommitdiffstats
path: root/bsc-nat
diff options
context:
space:
mode:
authorHarald Welte <laforge@gnumonks.org>2018-05-23 20:27:02 +0200
committerHarald Welte <laforge@gnumonks.org>2018-05-23 20:27:02 +0200
commit9220f6336e0716849ab4ebaa35b71adfe179da8d (patch)
tree4031eeb1f917c10527226bca4dd03cbae1f05173 /bsc-nat
parent898a7e06cc94de19bde28e9823a0bec6ca92a5c0 (diff)
Print more self-explanatory error message on bind/connect failures
When sockets cannot be bound or connected, the existing TTCN-3 code prints the following rather cryptic error messages: "IPA-CTRL-IPA(47)@f70ff1fd5cfd: Dynamic test case error: Using the value of an optional field containing omit. (Transport endpoint is not connected)" The "Transport endpoint is not connected" sort-of gives it away, but let's make it more explicit by introducing explicit checks for the res.connId and manual setverdict(fail) statements with proper error message. Change-Id: Id22a1b5189d81c4fca03d5e7aff60ffdd1ad56bf
Diffstat (limited to 'bsc-nat')
-rw-r--r--bsc-nat/MGCP_Adapter.ttcn4
1 files changed, 4 insertions, 0 deletions
diff --git a/bsc-nat/MGCP_Adapter.ttcn b/bsc-nat/MGCP_Adapter.ttcn
index 1351997c..6491c685 100644
--- a/bsc-nat/MGCP_Adapter.ttcn
+++ b/bsc-nat/MGCP_Adapter.ttcn
@@ -47,6 +47,10 @@ function main() runs on MGCP_Adapter_CT {
res := MGCP_CodecPort_CtrlFunct.f_IPL4_connect(MGCP_UDP, mp_mgw_ip, mp_mgw_udp_port,
mp_callagent_ip, mp_callagent_udp_port,
0, { udp:={} });
+ if (not ispresent(res.connId)) {
+ setverdict(fail, "Could not connect MGCP, check your configuration");
+ self.stop;
+ }
g_mgcp_conn_id := res.connId;
while (true) {