summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDaniel Willmann <dwillmann@sysmocom.de>2021-02-11 14:22:42 +0100
committerDaniel Willmann <dwillmann@sysmocom.de>2021-02-11 15:16:57 +0100
commit325458ddf7b25815de68454644697f56f97ad640 (patch)
tree4dedc12cd8c2b6e22e1efff61948cb875c0053b3
parent24f921baea8848074b61ffc4a75396307cb31af4 (diff)
gbproxy: Fix TC_dl_unitdata test failure introduced by 6ee0126971
This commit used a send template (ts) to match a received BSSGP PDU which doesn't work due to some differences in the length field. Use tr_BSSGP_IMSI again and change the template restrictions so it compiles. Fixes: 6ee0126971c83fd60658761263af559a482f13d9 Change-Id: I85676e96f8d32a9d2c7deadc1d66707b6b8697d0
-rw-r--r--gbproxy/GBProxy_Tests.ttcn2
-rw-r--r--library/Osmocom_Gb_Types.ttcn2
2 files changed, 2 insertions, 2 deletions
diff --git a/gbproxy/GBProxy_Tests.ttcn b/gbproxy/GBProxy_Tests.ttcn
index af9646c9..e12d69fe 100644
--- a/gbproxy/GBProxy_Tests.ttcn
+++ b/gbproxy/GBProxy_Tests.ttcn
@@ -1105,7 +1105,7 @@ private function f_TC_dl_unitdata(charstring id) runs on BSSGP_ConnHdlr {
ts_BSSGP_DL_UD(g_pars.tlli, payload, omit, ts_BSSGP_IMSI(g_pars.imsi));
/* we cannot use pdu_tx as there are some subtle differences in the length field :/ */
var template (present) PDU_BSSGP pdu_rx :=
- tr_BSSGP_DL_UD(g_pars.tlli, payload, ts_BSSGP_IMSI(g_pars.imsi));
+ tr_BSSGP_DL_UD(g_pars.tlli, payload, tr_BSSGP_IMSI(g_pars.imsi));
log("DL-UNITDATA(payload_size=", i);
f_sgsn2pcu(pdu_tx, pdu_rx);
diff --git a/library/Osmocom_Gb_Types.ttcn b/library/Osmocom_Gb_Types.ttcn
index 687a073f..76988b51 100644
--- a/library/Osmocom_Gb_Types.ttcn
+++ b/library/Osmocom_Gb_Types.ttcn
@@ -1815,7 +1815,7 @@ octetstring sdu) := {
}
}
template (present) PDU_BSSGP tr_BSSGP_DL_UD(template (present) GprsTlli tlli, template (present) octetstring pdu,
- template (omit) IMSI_BSSGP imsi := omit) := {
+ template IMSI_BSSGP imsi := omit) := {
pDU_BSSGP_DL_UNITDATA := {
bssgpPduType := '00'O,
tLLI_current := tlli,