AgeCommit message (Collapse)AuthorFilesLines
2018-09-12Install sample cfg file to /etc/osmocompespin/systemdPau Espin Pedrol5-1/+13
Change-Id: I48ddd65125f25ac9f2d03bd43e7ab0a0bcf18196
2018-09-10Install systemd services with autotoolsPau Espin Pedrol7-2/+32
Change-Id: I672f49f1034554ce62347ff9493eca18340deb3a
2018-09-06debian: Use osmo-sip-connector.service from contribPau Espin Pedrol2-12/+1
Use a symlink to avoid duplicating content. Remove nonsense Wants= line on itself. Change-Id: I556a91e012692c4073b4b832bccce0c850f684f8
2018-09-04Log using GSM48 Cause Value stringsKeith2-8/+8
Use gsm48_cc_cause_name() in logging messages Depends-On: I296f208581ce2550805f9d96e20f7319e1199023 Change-Id: I6e3541b66cb3407f0cb23fb6e00a04685fe90757
2018-09-04Cosmetic: correct spelling error in loggingKeith1-1/+1
Change-Id: I1f323a738f2c8ff21984b574a0ff47fe175e9161
2018-09-04Logging: Add debug logging for status/causesKeith2-3/+9
Adds some DEBUG level logging for SIP status and MNCC causes. Change-Id: Ib56e34ba079c7927e932c1b29d3e8341b8099ae0 Use --enable-werror optionPau Espin Pedrol1-1/+1
Change-Id: I8cfad742e6ce766b022ecdf4c78495accc9405d0 Introduce --enable-werror optionPau Espin Pedrol1-0/+23
Change-Id: I1666df1721ba9acc950612558e07a1a2e7b2bb85
2018-09-03mncc: Fix missing conditional clausePau Espin Pedrol1-3/+6
Fixes following compilation warning: osmo-sip-connector/src/mncc.c: In function ‘check_disc_ind’: osmo-sip-connector/src/mncc.c:517:2: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation] if (other_leg) ^~ Fixes: 008915ee41900c34ec0fd8df0c9f1d7c2cbdb3b2 ("Implement Cause Mapping") Change-Id: I5bdbc29a3f82bdc92b156c1f7df68c9503f85f8f
2018-08-31Implement Cause MappingKeith3-2/+25
Adds cause field to the call_leg and sip_call_leg structs. Translates the SIP status to MNCC cause and vice versa and uses this information in the SIP/MNCC messages at call leg release time. Change-Id: Ic1b80dff7e583cd6fff2b662bc6cc4bad3f81cd4
2018-08-31Add SIP <-> MNCC Cause MapKeith1-0/+88
Implements a cause_map, mapping the SIP status codes to GSM48_CC_CAUSE_* that are defined in libosmocore. The map at the same time implements the Q.850 cause texts that are subsequently used in the SIP Reason: header. Implements two functions cause2status() and status2cause() to read the map and return the the mapped status. The mapping mostly follows the implemention in the LCR program, so that any implementation relying on that mapping should continue to work as expected with osmo-sip-connector. Change-Id: Id82be8603a30a6aec28fc0258236c1746973db58
2018-08-28Use htonl, not ntohl before inet_ntoa()Keith Whyte1-1/+1
Change-Id: I805864759c287ad4e1d74e5f6ee16bf2d6a1b01f
2018-08-28Logging: Log RTP IP in dotted quad format.Keith Whyte1-2/+3
in check_rtp_create() log the IP address in human readable dotted quad format. Change-Id: I298b13836cc6b9c5888f931deca61132d31da035
2018-08-06debian/rules: Don't overwrite .tarball-versionHarald Welte1-4/+0
The .tarball-version file should contain the *source version* uniquely identifying the git commit, and not the Debian package name. With there is a correct .tarball-version file in the .tar.xz of the nightly source packages. Change-Id: Ia277b1d41c3f5b81a2c909320d23c2e763feac28 Related: OS#3449
2018-05-28Add Cause to DISCONNECT and RELEASE RequestsKeith1-7/+12
GSM 04.08 (Table 10.85) states: Coding standards other than the standard defined for the GSM PLMNS shall not be used if the cause can be represented with the GSM standardized coding. This patch adds cause coding GSM PLMS (3) and sets cause location to "public network serving the local user" (2) This prevents UE that pay attention to this from treating all call termination as an error and paves the way to adding correct cause mapping from Table 10.86 Also replaces use of magic numbers with enum constants. Change-Id: I5d3fe3f0c9e8de26dd0c73b10b7e4fc63dff3952
2018-05-24Logging: Log mncc_names in mncc_data()Keith4-3/+7
Links libosmocore (libosmogsm) for access to osmo_mncc_name() Remove reference to get_mncc_name() in src/mncc_protocol.h Uses osmo_mncc_name() to output to debug log which MNCC_* message was received. Change-Id: I161d1b841ac5fe1b7e092b329ae0674cb340f5ac
2018-05-06Bump version: → Espin Pedrol2-2/+23
Change-Id: Iefb8ada270a7a34d5db1c1e3c94f72a02e2dd609
2018-04-15use osmo_init_logging2() to avoid allocating from NULL contextHarald Welte1-1/+1
This requires libosmocore I216837780e9405fdaec8059c63d10699c695b360 or later to work. Change-Id: Id704689c9ad35a0db97aedae014e8b36eb1f86e2
2018-04-15sip: Register log callback function with sofia-sipHarald Welte4-1/+33
sofia-sip allows applications to register a log backend function which will be called every time the library wants to log something. We register such a call-back and make it log using the libosmocore logging framework. The problem is that sofia-sip has its own log level management, and by the time the message hits libosmocore, we don't know which log level we shall use :( Change-Id: Ib269b6b50f9d79bbd13acc43a626834921f05edb Related: OS#3105
2018-03-27osmoappdesc: Fix VTY prompt to use OsmoSIPcon, not old OsmoMNCCHarald Welte1-1/+1
In Change-Id Iba20c1c90e528d08bd362be39d86317569c253e6 we changed the prompt, but didn't update Change-Id: I7c7868bda2195e5e67b2db5824caee8fbfb5a3b6
2018-03-23Call the program "OsmoSIPcon" (also in vty)Harald Welte2-2/+2
It's confusing to access the telnet interface and then see a prompt that's not like the program name Change-Id: Iba20c1c90e528d08bd362be39d86317569c253e6
2018-03-19mncc: use 'const' to denote read-only input buffer/messageHarald Welte1-37/+37
We normally use the 'const' modifier whenever using read-only input data, let's do so in the mncc parser/handler, too. Change-Id: Ide24feb536c04fe7ef08c62b4498fdd95605b58c
2018-03-19commentsHarald Welte1-0/+14
Change-Id: Icf0e9211a4e93eb1b05b5a5d68f9ba766982da8d
2018-02-20contrib: Disable doxygen in libosmocore buildPau Espin Pedrol1-1/+1
Change-Id: I7befa0cb4e72a6ad086e3c2d290546dbf22f1676
2018-02-16contrib: Add systemd service filePau Espin Pedrol1-0/+12
Change-Id: I36dd16b75beb4d9bd8081aca6e44c5b72e58fead
2018-02-09debian/control: Fix URLs for homepage / gitHarald Welte1-3/+3
Change-Id: Ib431d5dcaf78cc31dbfaa4fd13105ec62142e9be
2017-11-07mncc.c: Ensure proper string buffer NUL terminationHarald Welte1-2/+2
Change-Id: I2f58a495f60ed744c1f625dc8df56aa4dc0aa4cb Fixes: Coverity CID#92223
2017-11-01vty: skip installing cmds now always installed by defaultNeels Hofmeyr1-3/+0
vty_install_default() and install_default() will soon be deprecated. Depends: I5021c64a787b63314e0f2f1cba0b8fc7bff4f09b Change-Id: I97dab6871ff37279be2caf24a8e8dc6af39d1e06
2017-10-28Tag/Release Version Welte1-0/+61
Change-Id: Id3876b2d940b5612788760dfeabe308f43d42ae2 Depend on latest upstream libosmo-*Harald Welte1-2/+2
Change-Id: I9bb7ced1197effb1082a57b2ed060d94ab9648c8
2017-10-28Fix git-version-genHarald Welte1-2/+2
It seems we didn't import a proper/clean git-version-gen into the repository. Let's fix this. Change-Id: I5132d10b3ed5a75e562cdd74db02eda68d828a08
2017-10-27jenkins: use before and after buildNeels Hofmeyr1-1/+4
See osmo-ci change I2409b2928b4d7ebbd6c005097d4ad7337307dd93 for rationale. Depends: I2409b2928b4d7ebbd6c005097d4ad7337307dd93 Change-Id: I7e9f19755f55b274def9d757f72f2a08a01a4cce
2017-09-19vty: install default commands for SIP,MNCC,APP_NODENeels Hofmeyr1-0/+3
Change-Id: Iee51881cc07d56209647fb4f505f8f6be6b885f0
2017-09-03sdp.c Send octet-align in fmtpKeith1-1/+10
rfc4867 8.2: octet-align: Permissible values are 0 and 1. If 1, octet-aligned operation SHALL be used. If 0 or if not present, bandwidth-efficient operation is employed. We don't have any support for AMR BE mode, but if we don't send this the other end expects BE mode and can't decode the stream Change-Id: I938758ac4ec55db9223e3da6c3c277e8fa670055
2017-09-01Fix build after recent libosmocore updateMax1-1/+1
Change-Id: Idd1eba7ed0c5454de29d86a8bb72beb24d03ef2a
2017-08-26Use release helper from libosmocoreMax3-0/+9
Change-Id: I1a65695d6191aa7647b9872e58da4a00bbad59e2 Related: OS#1861
2017-08-25Add git review configMax1-0/+4
Change-Id: I60f6b29998954b0698e523efaa766f8bb895cdf7
2017-03-23mncc/sip: Attempt to parse the media from session in progressHolger Hans Peter Freyther2-4/+17
Parse the media from session in progress and if present in alerting connect the call early. Sadly this sets RTP to the sendrecv mode even if we would like to keep it as recvonly. Change-Id: I98d173abc46c67b87666ed2f193a581d6e72344b Related: OS#1784
2017-03-23mncc: Enable in-band signalling for early mediaHolger Hans Peter Freyther1-1/+9
Besides sending the alerting request we should inform the MS that there is in-band information now. We do not seem to export these flags in protocol/gsm_04_08.h so hardcode them for now (until I come up with good names for them). Related: OS#1784 Change-Id: I80b1e1f4ca045bd63536476702a5812f27d9b36d
2017-03-23dtmf: Forward DTMF from MNCC to SIPHolger Hans Peter Freyther3-0/+29
We are not using the RTP telephony-event here but the older dtmf relay. We also only have a fixed DTMF duration for now. Change-Id: Icf770fae89f7aedf6eba9a119db9b8acc7f938df
2017-03-23testpbx: Add another number that will just play a ringbackHolger Hans Peter Freyther1-0/+10
This will enable early media to play a ringback to the phone. Change-Id: I4c778b1f0e7484a755716133f91767af8b1102c0
2017-03-23sip: Actually honor the remote port of the pbxHolger Hans Peter Freyther1-4/+6
So far the remote_port has never been used. sofia-sip did the right thing and put the port into the "Contact" and the rport option for the via. But we would have never been able to connect a PBX on a different port (as sofia-sip seems to parse the destination from the to address). Change-Id: Ifbd49b4aa6b01b118fe67e39dddef50b2946159c
2017-03-23testpbx: Enable GSM and AMR as codecs to actually be relevantHolger Hans Peter Freyther1-2/+2
Without these codecs we will not have much joy when working with a default GSM BTS/BSC. Change-Id: I8719c392f57e0dbed0c0c792d1381592dcd662c1
2017-03-23dtmf: Start handling the DTMF MNCC messages and respondHolger Hans Peter Freyther1-7/+59
Simply respond to the dtmf start/stop with a response and move on. Change-Id: Iffc92ea2112c9943ce89c244a9b323125c352ae5
2017-03-16jenkins: add value_string termination checkNeels Hofmeyr1-0/+2
Change-Id: Ic247005aeeabdf349caf48657af0249da8c8d9ea Depends: libosmocore change-id I2bc93ab4781487e7685cfb63091a489cd126b1a8
2017-03-08evpoll: Add workaround for usage of IP_RECVERR in sofia-sipHolger Hans Peter Freyther1-1/+1
We are using glib to benefit from the sofia-sip-glib eventloop integration and set a poll func (evpoll) to be called by glib to integrate with the rest of libosmocore. Sofia-sip will use IP_RECVERR to enable error reporting on the socket and then sets SU_WAIT_ERR (mapped to POLLERR if not using kqueue) in the internal events flag of the socket. This will be registered with a su_wait (mapped to struct pollfd) and then glib will be called with g_source_add_poll. At this point the the fd->events will still have the POLLERR bit set. Before glib is calling its internal poll routine or our one it will copy all registered fd into an array and mask the events flags: /* In direct contradiction to the Unix98 spec, IRIX runs into * difficulty if you pass in POLLERR, POLLHUP or POLLNVAL * flags in the events field of the pollfd while it should * just ignoring them. So we mask them out here. */ events = pollrec->fd->events & ~(G_IO_ERR|G_IO_HUP|G_IO_NVAL); This leads to the POLLERR flag never been set in the revents of the struct poll_fd and as such we never put them in the exceptionset and as such: static int tport_base_wakeup(tport_t *self, int events) { int error = 0; if (events & SU_WAIT_ERR) error = tport_error_event(self); tport_base_wakeup will never call tport_error_event. And the error will be stuck in the socket data forever and recvmsg will return a zero length packet. And this will repeat until the end of time. As a first hack I mapped SU_WAIT_ERR to POLLPRI but when using select the Linux kernel will not put the socket error into the except queue unless the sockopt SOCK_SELECT_ERR_QUEUE is used. One option is to use poll and then map the select requirements to poll. Right now I just signal POLLERR as well to trigger tport_error_event. This will result in extra syscalls for each received UDP message right now. Change-Id: I5bec4a7b70f421ab670e649e5bc1ea6faf59707c
2017-03-06mncc: Fix use after free on mncc socket disconnectionHolger Hans Peter Freyther1-5/+12
When the MNCC socket breaks down we would release all callds but when there is no remote call the call would be released before if (call->remote) ... is being executed leading to a use after free. Fix it by copying the legs first and assuming the call will be gone after that. ==3618== Invalid read of size 4 ==3618== at 0x804A18A: app_mncc_disconnected (app.c:49) ==3618== by 0x804B52D: close_connection (mncc.c:255) ==3618== by 0x804BCFA: mncc_rtp_send.constprop.13 (mncc.c:145) ==3618== by 0x804CC86: check_setup (mncc.c:435) ==3618== by 0x804CC86: mncc_data (mncc.c:795) ==3618== by 0x42FCF94: osmo_fd_disp_fds (select.c:167) ==3618== by 0x804D1F2: evpoll (evpoll.c:92) ==3618== by 0x4205053: ??? (in /lib/i386-linux-gnu/ ==3618== by 0x4205478: g_main_loop_run (in /lib/i386-linux-gnu/ ==3618== by 0x8049AA6: main (main.c:171) ==3618== Address 0x47f3258 is 64 bytes inside a block of size 76 free'd ==3618== at 0x402A3A8: free (vg_replace_malloc.c:473) ==3618== by 0x42E7FD1: ??? (in /usr/lib/i386-linux-gnu/ ==3618== by 0x804A3FD: call_leg_release (call.c:87) ==3618== by 0x804A186: app_mncc_disconnected (app.c:48) ==3618== by 0x804B52D: close_connection (mncc.c:255) ==3618== by 0x804BCFA: mncc_rtp_send.constprop.13 (mncc.c:145) ==3618== by 0x804CC86: check_setup (mncc.c:435) ==3618== by 0x804CC86: mncc_data (mncc.c:795) ==3618== by 0x42FCF94: osmo_fd_disp_fds (select.c:167) ==3618== by 0x804D1F2: evpoll (evpoll.c:92) ==3618== by 0x4205053: ??? (in /lib/i386-linux-gnu/ ==3618== by 0x4205478: g_main_loop_run (in /lib/i386-linux-gnu/ ==3618== by 0x8049AA6: main (main.c:171) ==3618== Change-Id: I1889013ed315f896e4295358f6daf76ce523dc2a
2017-03-06call: Fix call release handling on mncc connection lossHolger Hans Peter Freyther1-2/+2
The app_mncc_disconnected will be called when the MNCC socket is down and lead to all calls being released. It directly released the call but did not stop the MNCC CMD timer. Go through the call release callback. ==3618== at 0x804A18A: app_mncc_disconnected (app.c:49) ==3618== by 0x804B52D: close_connection (mncc.c:255) This lead to the timer not being removed: ==3593== Invalid read of size 4 ==3593== at 0x4305D42: rb_first (rbtree.c:294) ==3593== by 0x42FCB37: osmo_timers_update (timer.c:220) ==3593== by 0x804D1D5: evpoll (evpoll.c:89) ==3593== by 0x4205053: ??? (in /lib/i386-linux-gnu/ ==3593== by 0x4205478: g_main_loop_run (in /lib/i386-linux-gnu/ ==3593== by 0x8049AA6: main (main.c:171) ==3593== Address 0x47f3380 is 232 bytes inside a block of size 272 free'd ==3593== at 0x402A3A8: free (vg_replace_malloc.c:473) ==3593== by 0x42E7FD1: ??? (in /usr/lib/i386-linux-gnu/ ==3593== by 0x804A3C4: call_leg_release (call.c:83) ==3593== by 0x804A188: app_mncc_disconnected (app.c:48) ==3593== by 0x804B52D: close_connection (mncc.c:255) ==3593== by 0x804BCFA: mncc_rtp_send.constprop.13 (mncc.c:145) ==3593== by 0x804CC86: check_setup (mncc.c:435) ==3593== by 0x804CC86: mncc_data (mncc.c:795) ==3593== by 0x42FCF94: osmo_fd_disp_fds (select.c:167) ==3593== by 0x804D1F2: evpoll (evpoll.c:92) ==3593== by 0x4205053: ??? (in /lib/i386-linux-gnu/ ==3593== by 0x4205478: g_main_loop_run (in /lib/i386-linux-gnu/ ==3593== by 0x8049AA6: main (main.c:171) Change-Id: I2e8e14b3983f84c9be046bbd96bbcd1e5766993e
2017-03-05contrib: Add Dockerfile to build and configure a FreeSWITCHHolger Hans Peter Freyther9-0/+2053
Rhizomatica is using FreeSWITCH and we should have an easy way to test against it. A docker container with exposed ports seems like the easiest. FreeSWITCH by default is giving us some exmaple numbers: * 5000 a menu... that allows DTMF * 9195 an echo test * 9198 tetris. The config is copied on top of the default/big config that is installed. If this PBX should be reached from the outside one needs to change to the external address and maybe configure the acl as well to add more CIDRs. Besides that make container make run Will build it and start the container. Takes a bit of time and requires docker. With it configure one can see things like: 2017-03-05 15:32:49.913912 [INFO] switch_channel.c:515 RECV DTMF 3:2000 2017-03-05 15:32:50.952752 [INFO] switch_channel.c:515 RECV DTMF 2:2000 Now to test DTMF in the system. Change-Id: I7f3aa8c81b9e8698df090a05d2e41a41b67d8e3c
2017-02-11evpoll: Don't try to be more smart than g_pollHolger Hans Peter Freyther1-4/+4
gpoll.c:g_poll maps G_IO_PRI (which is POLLPRI) to the errorfds of the select call. Let's do the same. Change-Id: I8c9163f7495e0b237bde2d48beffea3b0776a1dd Related: OS#1934