From 6626bbc2151fc57ffb7c203a6d0ac8ee07036ca7 Mon Sep 17 00:00:00 2001 From: Daniel Willmann Date: Wed, 2 Dec 2020 17:46:56 +0100 Subject: gbproxy: Add todos encountered while going through the code Change-Id: I8c3a788f008d3cb2d067d974c2b1b9ca45185d8d --- src/gbproxy/gb_proxy.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'src') diff --git a/src/gbproxy/gb_proxy.c b/src/gbproxy/gb_proxy.c index 2c58e805b..0d79ff7eb 100644 --- a/src/gbproxy/gb_proxy.c +++ b/src/gbproxy/gb_proxy.c @@ -936,6 +936,7 @@ static int gbprox_rx_ptp_from_bss(struct gbproxy_config *cfg, &ns_bvci, msg); } + /* TODO: Should we discard this message if the check fails */ check_peer_nsei(peer, nsei); rc = gbprox_process_bssgp_ul(cfg, msg, peer); @@ -1390,7 +1391,7 @@ static int gbprox_rx_sig_from_sgsn(struct gbproxy_config *cfg, LOGP(DGPRS, LOGL_NOTICE, "NSE(%05u/SGSN) BSSGP " "%sBLOCK_ACK for signalling BVCI ?!?\n", nsei, pdu_type == BSSGP_PDUT_BVC_UNBLOCK_ACK ? "UN":""); - /* should we send STATUS ? */ + /* TODO: should we send STATUS ? */ rate_ctr_inc(&cfg->ctrg-> ctr[GBPROX_GLOB_CTR_INV_BVCI]); } else { -- cgit v1.2.3