From c44af53d1e4c56de41b53ee13a5a72b440640e52 Mon Sep 17 00:00:00 2001 From: Alexander Couzens Date: Mon, 12 Aug 2019 18:29:57 +0200 Subject: gprs_gmm: clarify comment of Iu follow-on request Change-Id: Ib6b3a1b250de373656310a3c8f88d1d39bdcee60 --- src/gprs/gprs_gmm.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/src/gprs/gprs_gmm.c b/src/gprs/gprs_gmm.c index d23215622..185cd9ad8 100644 --- a/src/gprs/gprs_gmm.c +++ b/src/gprs/gprs_gmm.c @@ -1404,7 +1404,11 @@ static int gsm48_rx_gmm_att_req(struct sgsn_mm_ctx *ctx, struct msgb *msg, goto err_inval; cur += msnc_len; - /* TODO: In iu mode - handle follow-on request */ + /* TODO: In iu mode - handle follow-on request. + * The follow-on request can be signaled in an Attach Request on IuPS. + * This means the MS/UE asks to keep the PS connection open for further requests + * after the Attach Request succeed. + * The SGSN can decide if it close the connection or not. Both are spec conform. */ /* aTTACH Type 10.5.5.2 */ att_type = *cur++ & 0x07; @@ -1742,7 +1746,11 @@ static int gsm48_rx_gmm_ra_upd_req(struct sgsn_mm_ctx *mmctx, struct msgb *msg, enum gsm48_gmm_cause reject_cause = GMM_CAUSE_PROTO_ERR_UNSPEC; int rc; - /* TODO: In iu mode - handle follow-on request */ + /* TODO: In iu mode - handle follow-on request. + * The follow-on request can be signaled in an Attach Request on IuPS. + * This means the MS/UE asks to keep the PS connection open for further requests + * after the Attach Request succeed. + * The SGSN can decide if it close the connection or not. Both are spec conform. */ /* Update Type 10.5.5.18 */ upd_type = *cur++ & 0x07; -- cgit v1.2.3