AgeCommit message (Collapse)AuthorFilesLines
2019-11-21gprs_gmm.c: Send XID reset with received TLLIpespin/fixPau Espin Pedrol1-2/+6
Otherwise lower layers will end up using a TLLI from PTMSI which was not yet announced to the MS if it is still not in GMM attached state, as showcased by SGSN_Tests.TC_attach_req_id_req_ra_update. Change-Id: Ide51726abb82f5784eca4ab8d62b2ad8512be843
2019-11-21gprs_llc.c: Use enum instead of hardcoded valuePau Espin Pedrol1-1/+1
Change-Id: I89815f44f615a188f46a13f3785b3f7484f73bb3
2019-11-21Improve logging in gprs_llc.c codePau Espin Pedrol3-11/+26
Change-Id: Id89cc6760179fb9b1709a30b5d1af41d466b280b
2019-11-08gmm: Fix assertion hit during RA UPD REQ before completting gmm attachPau Espin Pedrol1-2/+2
Output: 20191107021548500 DMM <0002> gprs_gb.c:40 MM_STATE_Gb(2596296189)[0x6120000084a0]{Idle}: Received Event E_MM_PDU_RECEPTION 20191107021548500 DMM <0002> gprs_gmm.c:1531 MM(/d4b6d7af) -> GMM RA UPDATE REQUEST type="RA updating" 20191107021548501 DMM <0002> gprs_gmm.c:1615 MM(/d4b6d7af) The MM context cannot be used, RA: 901-70-2758-208 Assert failed mmctx->gb.llme == NULL gprs_gmm.c:1620 Scenario reproducing the crash can be triggered with TTCN3 SGSN_Tests.TC_attach_req_id_req_ra_update. Basically, SGSN first receives an ATTACH REQ with a given RA ID, then SGSN switches to state CommonProcedureInitiated and sends GMM ID REQ, and MS/PCU answers immediatelly with a RA Update instead with a new RA ID. Related: OS#3957, OS#4245 Change-Id: I64fa5cf1b427d3abb99e553e584897261a827ce6
2019-10-21sgsn_libgtp.c: Drop use of deprecated libgtp APIs gtp_retrans*()Pau Espin Pedrol3-28/+3
Since osmo-ggsn.git c94837c6a401bf0f80791b619a9b4cfbe9160afd, those APIs are a no-op since timers are tracked internally through osmocom APIs (and at the same time, new implementation fixes some timing related bugs). As a result, osmo-sgsn depends now on at least that libgtp commit. Since it's not yet avaiable on latest libgtp release, let's track it down in TODO-RELESE to not forget to update libgtp requirements during osmo-sgsn release. Related: OS#4178 Change-Id: Ia9a93d4a6ed63cd0c736f9a99d81d730b958d82e
2019-10-17sgsn: Gb: implementing PS Paging when MS is MM_STANDBYAlexander Couzens1-0/+6
When the MS is in MM_STANDBY, the Routing Area is known, but not the exact cell. Start the paging procedure. (Even this is only supported for the last known cell, not the Routing Area. Routing Area paging is not yet supported.) Change-Id: Icc2c6ba70f8f74054546a1e31741fc90b232a23c
2019-10-17sgsn_libgtp: refactor ps paging into gprs_gbAlexander Couzens3-11/+28
Paging should be done in gprs_gb Change-Id: I3020020f52005aa460ca6b245ee2297aec9821b3
2019-10-09gprs_mm_state_iu_fsm.c: fix: assign timer_cb to mm_state_iu_fsmVadim Yanitskiy1-0/+1
GCC warns us that 'pmm_state_fsm_timer_cb' is defined but not used. This function was introduced in [1], but was not assigned to the FSM. [1] I66c2ac0350cb074aefd9a22c5121acf723f239d3 Change-Id: Ib040befc87b2676aad2b8fe3671404fb3f5b030b
2019-10-08sgsn_mm_ctx_alloc(): check for unallocated fsmsAlexander Couzens1-0/+25
Change-Id: I867612a60236eaf7009400c92f5d871006aaf008
2019-10-08gprs_gmm: release Iu connection on RAU failuresAlexander Couzens1-0/+6
When a RAU fails without an a GMM context, release the Iu connection after sending a response. Change-Id: I05a9200f55d608ccfb3f86184c324a2b428da76b
2019-10-08ranap: add non-spec X1001Alexander Couzens3-3/+12
When the SGSN releases a RANAP connection, it sends a Release Command and waits for a Release Complete. Use X1001 to release the Iu connection when the Release Complete is lost/never received. Change-Id: I39a0169c22a4ac430b3d6f3c281d1f381eaa4756
2019-10-08sgsn: MM Gb Fsm: fix event handling for implicit detachAlexander Couzens1-1/+3
Implicit detach means there won't be any Gb state afterwards. Change-Id: Iececb730e7135e14ebd94f82edb79b03ced1f9e3
2019-10-08gprs_sgsn: always allocate Gb/Iu mm fsmAlexander Couzens1-6/+6
When moving between RANs we need them at a later point. Allocate them always to not make the code (more) complex. Change-Id: I1724790335b0820f153a0cbdb5cfd1cfea36d1e9
2019-10-08gprs_ranap: add missing rc = 0Alexander Couzens1-0/+1
After processing the event, set the return code to success. Thanks to manatails (redmine). Change-Id: I73b3b3c3dd330bc953835737758854cf68539495 Fixes: #3969
2019-10-08gprs_mm_state_gb_fsm: ensure T3350 is not running when entering IDLEAlexander Couzens1-0/+4
In IDLE there is not further context with the MS. Prevents the Timer from sending packages to a MS which can not respond Change-Id: Ibdd913173af11d0e6d04aa392e047d5d9aee1243
2019-10-08gprs_ranap: on Iu release, stop the attach fsm if runningAlexander Couzens1-0/+3
A Iu release should stop any active procedure. Change-Id: I78c6c0c4024657212d6abef51e226ce233018fee
2019-10-08Iu: implement a user inactivity timerAlexander Couzens4-2/+29
The user inactivity timer is similiar to the Gb READY timer and reduces the resources taken by an idle UE. Change-Id: I66c2ac0350cb074aefd9a22c5121acf723f239d3
2019-10-03gprs_ranap: release Iu UE Context when exiting PMM ConnectedAlexander Couzens3-2/+52
PMM Connected defines a Iu signaling connection. The 2 other PMM states do not have an active Iu signaling connection. Change-Id: Ie05d2bdf8dfb593b4c7e837107a3a06f22e90119
2019-10-03Avoid compiling unneeded files when building without IuAlexander Couzens3-8/+7
Remove gprs_ranap.c and gprs_mm_state_iu_fsm.c from the Makefile when building without IU. Change-Id: I2386f8e86bbf0b87eedce9f57eb86b1b64998a69
2019-09-28sgsn: when receiving data PDU notify the Gb GMM fsmAlexander Couzens3-2/+21
When receiving a PDU, the GMM fsm will change to state MM_READY and will re-arm the T3314 Relates: OS#1941 Change-Id: I78f40762fb17bbd4a6f35608a793f8e5271e9b86
2019-09-19Introduce TODO-RELEASE filePau Espin Pedrol1-0/+1
It's going to be useful to track new dependency APIs being used which require dependency version release and version bump during release of osmo-sgsn. Change-Id: Ia495a8577001c6a223c31f4ddd7eee289e3523c7
2019-09-12gprs_ranap: refactor REQUIRE_MM defineAlexander Couzens1-16/+6
All branches need a MM context. Exit early if no MM context present. Change-Id: Ifa4c55f1f2c199fa63bd755311026b8586a65f3f
2019-09-12mm_gb_fsm: unassign the llme when entering MM_IDLEAlexander Couzens1-0/+11
MM_IDLE means there is no known state to this MM. Change-Id: Ieb0d6cea828842763c13942fe1a63dd89399f799
2019-09-12gprs_ranap: send CommonId after receiving Security Mode CompleteAlexander Couzens1-0/+1
After Security Mode Complete, the sender has been authenticated. Send a CommonId to enable paging coordination between CS and PS. Change-Id: If195c26e87ba3054e159746671babf93a12e7013
2019-09-10sgsn_pdp_ctx_terminate: check llme before accessingAlexander Couzens1-1/+2
Change-Id: Ib4361cdc12f9c1674c89c6fafeeb52a3f42abe1d
2019-09-06sgsn: Reject PdpActReq if no GTP pdp ctx existsPau Espin Pedrol1-0/+5
It could happen that SGSN drops GTP side of a pdp ctx (pdp->lib=NULL) while still maintaing the other side (to notify about the entire pdp ctx being torn down). If a PdpActReq arrives during that time, we need to account for that situation, otherwise osmo-sgsn crashes accessing pdp->lib. If no pdp->lib is found at that time, let's reject the request and expect at some point later in time the entire pdp context will be destroyed and reestablished. Related: OS#4173 Change-Id: I6dd87557ebb26fdbd280504abde10d976acecf64
2019-09-03Split out GPRS SM layer into its own filePau Espin Pedrol11-709/+780
Change-Id: Ie61d22e7868af6de73cdf9c731f07130b282599d
2019-09-03Implement GMM State using osmocom FSMPau Espin Pedrol11-53/+261
State machine inspired in the one from TS 24.008 Some state transitions are inroduced in the code but are still commented out since we lack some functionalitites or improvements in the code to handle different scenarios. Most of the logic is still outside of the FSM, but at least now the states are handled in a sane way triggered by events. Change-Id: Idecb43c10d66224d4f9ba9320825040ce6cf9a07
2019-09-02enum gprs_gmm_state: Fix spec referencePau Espin Pedrol1-1/+1
Change-Id: I62121e46e5091e5b559397aa01f107ddc23e2c18
2019-09-02gmm: Move code handling GMM PTMSI Realloc Complete to its own functionPau Espin Pedrol1-11/+17
Change-Id: I3b21a976c6683bea5419a33f0ccb8b56483d6e21
2019-09-02gmm: Move code handling GMM Routing Area Update Complete to its own functionPau Espin Pedrol1-25/+32
Change-Id: I8e28ac03edf82374e804701ebe635e1171a2b36a
2019-09-02gmm: Move code handling GMM Attach Complete to its own functionPau Espin Pedrol1-33/+40
Change-Id: I2d8d947ab1eb4100f404b885461f7a30583c9ac6
2019-09-02Move out sgsn to its own subdirPau Espin Pedrol39-111/+143
Change-Id: I16fccc0eadf588599b9e5578d0f4dbaf9df81737
2019-09-02Move out gtphub to its own subdirPau Espin Pedrol13-27/+55
Change-Id: I707d5e9b775179e732d281ce3d245de83d648eea
2019-09-02Move out gbproxy to its own subdirPau Espin Pedrol15-30/+62
Change-Id: I2cc98d3a276d953609bbbbaa9782a0112687791e
2019-09-02src/gprs/Makefile.am: Move build of shared .c files to an internal libPau Espin Pedrol3-14/+27
Build files shared by osmo-sgsn, osmo-gbpy and osmo-gtphub into a .la library, so we can later split each application into its own subdir and clearly identify what's used by who. Due to a dependency error with .Po files, I cannot depend on the specific .o files directly in LDADD for each binary, but it works fine on follow up commits when binaries are splitted into different makefiles, so it will be done later. Change-Id: Ib7665c530c086a5f3135c395bb8bf19ed4a882b6
2019-09-02vty: Print MM state and RAN type in show mm-contextPau Espin Pedrol3-1/+16
Value presviosuly printed as MM state is actually usually refereed as GMM state, so rename it. Change-Id: Ia06c53f0cd2a6348237ed3abeb9367d965745aba
2019-09-02Introduce FSM mm_state_iu_fsmPau Espin Pedrol10-65/+165
Implement TS 23.060 6.1.2 Mobility Management States (Iu mode) using osmocom FSM and drop old implementation. Most of the logic on each state is still kept in gprs_gmm.c, will be inserted into the FSM later. Change-Id: I4c9cf8c27194817c56e8949af0205e1cc14af317
2019-09-02Introduce FSM mm_state_gb_fsmPau Espin Pedrol10-125/+154
Implement TS 23.060 6.1.1 Mobility Management States (A/Gb mode) using osmocom FSM and drop old implementation. Most of the logic on each state is still kept in gprs_gmm.c, will be inserted into the FSM later. Change-Id: I04004423e993107374d5a3549b8a93ac169251dd
2019-09-02sgsn_vty: Print correct Iu mmctx id in 'show mm-context'Pau Espin Pedrol1-1/+14
Change-Id: I79333bef4a4bf743fcad07812c9a213b368ff2b6
2019-09-02sgsn_vty: Fix mmctx rate_ctr output indentationPau Espin Pedrol1-1/+1
Change-Id: I1b89c179e1ba08b65e31727fdce90c7b578f4d6d
2019-09-02sgsn_cdr.c: Fix ip addr string buffer sizePau Espin Pedrol1-3/+3
INET(6)_ADDRSTRLEN already contains the required extra null byte at the end, no need to add +1 to it. Change-Id: I5a16659e007c6883fe21582cce5dac544e6d4bb9
2019-09-02gprs_gmm.c: Replace inet_ntoa with inet_ntopPau Espin Pedrol1-3/+8
inet_ntop manual states: "inet_ntoa(3) is now considered to be deprecated in favor of inet_ntop()". Change-Id: I0c708d047122f349acf46797a9e5973040e7ae04
2019-09-02Merge common allocation steps for Gb and Iu ctxPau Espin Pedrol1-30/+27
This way it's easier to add new common functionalitites without forgetting to add it on both sides, and simplifies the code. Change-Id: Ib6c0427ac7b35295cf1caf2f28cb2a5c155b9d9c
2019-09-02Split enum gprs_pmm_state into Iu and Gb counterpartsPau Espin Pedrol6-36/+43
Those two state sets are not part of the same state machine, and are used in different scenarios, so let's split them and handle them in Gb and Iu specific parts of struct sgsn_mm_ctx. This is required in order to improve related code (for instance, use osmocom fsm). Change-Id: I6100d607da316da0595886c6968704dd9ccfbde9
2019-09-02Move llc->MM/SM Gb specific glue code to its own filePau Espin Pedrol7-62/+110
Now that we have RANAP/Iu handling specificities in its own file, let's have also Gb specific glue code for messages coming from llc up to MM/SM layer in its own file. This way same entry points in gprs_gmm.c are used by Gb and Iu: gsm0408_rcv_gmm() (for MM) and gsm0408_rcv_gsm() (for SM). Change-Id: Iaf57922a0970c1d03f6f1d6337d27ae3d4aaf32c
2019-09-02Move lots of Iu/ranap specific code into its own filePau Espin Pedrol11-238/+274
RANAP related functionalities were splitted among several files (gprs_gmm.c, gprs_sgsn.c and sgsn_libgtp.c). Let's move it into its own file to shrink complexity/size of existing files. It also allows to keep a lot of conditionally enabled code (BUILD_IU) and its dependencies (osmo-iuh) together. Change-Id: I549042aaff045a378de77d657cc396ee08f22f33
2019-09-02sgsn: gtp: Drop related pdp contexts on echo timeout against GGSNPau Espin Pedrol3-7/+16
Change-Id: I7e97bac1c13a2c26203eb64e590fd75d77eb44bd
2019-09-02Introduce log helper LOGGGSN and log category DGTPPau Espin Pedrol3-1/+13
It will be used in forthcoming commits. Change-Id: I30f46f44af1d0eee324b1a995c1dad2e1315af7c
2019-09-02gprs_gmm: gsm48_rx_gmm_att_req(): refactor duplicated codeAlexander Couzens1-10/+6
Change-Id: I709f847802a975e1a75d0b87ac5125240cfd0854