aboutsummaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorDaniel Willmann <dwillmann@sysmocom.de>2020-12-02 17:46:56 +0100
committerHarald Welte <laforge@osmocom.org>2020-12-02 22:42:48 +0100
commit6626bbc2151fc57ffb7c203a6d0ac8ee07036ca7 (patch)
treea70025e26219e504f678108cf578402be2818415 /src
parent103a7ec03320075a28eb160673c852244da68cf7 (diff)
gbproxy: Add todos encountered while going through the code
Diffstat (limited to 'src')
-rw-r--r--src/gbproxy/gb_proxy.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/src/gbproxy/gb_proxy.c b/src/gbproxy/gb_proxy.c
index 2c58e805..0d79ff7e 100644
--- a/src/gbproxy/gb_proxy.c
+++ b/src/gbproxy/gb_proxy.c
@@ -936,6 +936,7 @@ static int gbprox_rx_ptp_from_bss(struct gbproxy_config *cfg,
&ns_bvci, msg);
}
+ /* TODO: Should we discard this message if the check fails */
check_peer_nsei(peer, nsei);
rc = gbprox_process_bssgp_ul(cfg, msg, peer);
@@ -1390,7 +1391,7 @@ static int gbprox_rx_sig_from_sgsn(struct gbproxy_config *cfg,
LOGP(DGPRS, LOGL_NOTICE, "NSE(%05u/SGSN) BSSGP "
"%sBLOCK_ACK for signalling BVCI ?!?\n", nsei,
pdu_type == BSSGP_PDUT_BVC_UNBLOCK_ACK ? "UN":"");
- /* should we send STATUS ? */
+ /* TODO: should we send STATUS ? */
rate_ctr_inc(&cfg->ctrg->
ctr[GBPROX_GLOB_CTR_INV_BVCI]);
} else {