aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPau Espin Pedrol <pespin@sysmocom.de>2019-05-28 21:25:06 +0200
committerPau Espin Pedrol <pespin@sysmocom.de>2019-05-28 21:27:56 +0200
commit20795e3fda107f4b292497337fd1a35d74482342 (patch)
tree00bc069ddf1a57e11ebeae3cdca05dca43ca862e
parentba2e50039539606bd1cbee3e57f9a15069ab76ab (diff)
Document max retransmit times for T3395
Spec also states same value is used for T3390, which we don't yet implement. Change-Id: I1a2276bd42d1ea5706cf9cc26d3e44baa6fbf066
-rw-r--r--src/gprs/gprs_gmm.c7
1 files changed, 5 insertions, 2 deletions
diff --git a/src/gprs/gprs_gmm.c b/src/gprs/gprs_gmm.c
index a18a54e1..e7f0bfeb 100644
--- a/src/gprs/gprs_gmm.c
+++ b/src/gprs/gprs_gmm.c
@@ -67,6 +67,9 @@
#define PTMSI_ALLOC
+/* 3GPP TS 04.08 sec 6.1.3.4.3(.a) "Abnormal cases" */
+#define T339X_MAX_RETRANS 4
+
extern struct sgsn_instance *sgsn;
extern void *tall_sgsn_ctx;
@@ -2797,8 +2800,8 @@ static void pdpctx_timer_cb(void *_pdp)
switch (pdp->T) {
case 3395: /* waiting for PDP CTX DEACT ACK */
- if (pdp->num_T_exp >= 5) {
- LOGPDPCTXP(LOGL_NOTICE, pdp, "T3395 expired >= 5 times\n");
+ if (pdp->num_T_exp > T339X_MAX_RETRANS) {
+ LOGPDPCTXP(LOGL_NOTICE, pdp, "T3395 expired > %d times\n", T339X_MAX_RETRANS);
pdp->state = PDP_STATE_INACTIVE;
if (pdp->ggsn)
sgsn_delete_pdp_ctx(pdp);