From 6dacc35c751452f0e94acf15e6fd42ac774c8e53 Mon Sep 17 00:00:00 2001 From: Pau Espin Pedrol Date: Wed, 21 Nov 2018 19:49:12 +0100 Subject: bts: Fix TRX0 param initialization TRX0 is allocated in a different place than other TRX. Commit that introduced the bug added an initialization step (bts_trx_init) applied in VTY cmd "trx <0-254>", where TRX are allocated since same commit, but doesn't initialize TRX0 for reasons explained in first paragraph. As a result, some parameters were not applied to TRX0, like power ramping increment step, which prevented MS from finding the network in osmo-gsm-tester tests. Fixes: eebb6a4216f136132400831ca35ed70e7502e92a ("bts: Allocate TRX for BTS dynamically, deprecate -t") Change-Id: I5afd66548634ff53e2af24dc7055d408ca8ca4e3 --- src/common/vty.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'src/common/vty.c') diff --git a/src/common/vty.c b/src/common/vty.c index f3054139..7c2900f2 100644 --- a/src/common/vty.c +++ b/src/common/vty.c @@ -233,7 +233,10 @@ DEFUN(cfg_bts_trx, cfg_bts_trx_cmd, bts->num_trx, VTY_NEWLINE); return CMD_WARNING; } else if (trx_nr == bts->num_trx) { - /* allocate a new one */ + /* Allocate a new TRX + * Remark: TRX0 was already created during gsm_bts_alloc() and + * initialized in bts_init(), not here. + */ trx = gsm_bts_trx_alloc(bts); if (trx) bts_trx_init(trx); -- cgit v1.2.3