From dfa3bb8a10e9fd12e583f9e996679836793a55bd Mon Sep 17 00:00:00 2001 From: Harald Welte Date: Sat, 25 May 2019 10:19:00 +0200 Subject: Add severity to OML FAILURE EVENT REPORT Example: The fact that the PCU has connected with a given version is not a *failure* in the first place, particularly not a MAJOR one. Let's allow callers of oml_tx_failure_event_rep() specify the serverity of the event that they're reporting to the BSC. Change-Id: I49af04212568892648e0e8704ba1cc6de8c8ae89 --- src/common/rsl.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'src/common/rsl.c') diff --git a/src/common/rsl.c b/src/common/rsl.c index cc653ce2..92575b52 100644 --- a/src/common/rsl.c +++ b/src/common/rsl.c @@ -471,8 +471,8 @@ static int rsl_rx_paging_cmd(struct gsm_bts_trx *trx, struct msgb *msg) if (rc < 0) { /* FIXME: notfiy the BSC on other errors? */ if (rc == -ENOSPC) { - oml_tx_failure_event_rep(&trx->bts->mo, OSMO_EVT_MIN_PAG_TAB_FULL, - "BTS paging table is full"); + oml_tx_failure_event_rep(&trx->bts->mo, NM_SEVER_WARNING, + OSMO_EVT_MIN_PAG_TAB_FULL, "BTS paging table is full"); } } @@ -2013,7 +2013,7 @@ static int rsl_rx_ipac_XXcx(struct msgb *msg) if (!lchan->abis_ip.rtp_socket) { LOGPLCHAN(lchan, DRTP, LOGL_ERROR, "IPAC Failed to create RTP/RTCP sockets\n"); oml_tx_failure_event_rep(&lchan->ts->trx->mo, - OSMO_EVT_CRIT_RTP_TOUT, + NM_SEVER_MINOR, OSMO_EVT_CRIT_RTP_TOUT, "%s IPAC Failed to create RTP/RTCP sockets", gsm_lchan_name(lchan)); return tx_ipac_XXcx_nack(lchan, RSL_ERR_RES_UNAVAIL, @@ -2050,7 +2050,7 @@ static int rsl_rx_ipac_XXcx(struct msgb *msg) if (rc < 0) { LOGPLCHAN(lchan, DRTP, LOGL_ERROR, "IPAC Failed to bind RTP/RTCP sockets\n"); oml_tx_failure_event_rep(&lchan->ts->trx->mo, - OSMO_EVT_CRIT_RTP_TOUT, + NM_SEVER_MINOR, OSMO_EVT_CRIT_RTP_TOUT, "%s IPAC Failed to bind RTP/RTCP sockets", gsm_lchan_name(lchan)); osmo_rtp_socket_free(lchan->abis_ip.rtp_socket); -- cgit v1.2.3