aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHarald Welte <laforge@gnumonks.org>2019-05-24 10:29:39 +0200
committerHarald Welte <laforge@gnumonks.org>2019-05-24 11:08:20 +0200
commitb8265c63cc7d0b7060860d42dfc348423102d9c5 (patch)
tree5e8a6456527e81839bdf38c2e5218caaf27a7686
parent7f1b61df5f68d0f4ffffa1dd10517b1980783864 (diff)
oml: Have one generic log message for all transmitted messages
Rather than open-coding "Tx foobar..." in various functions (and forgetting it in half of them), let's add a generic message into oml_mo_send_msg(). Change-Id: I5dd4b1749e68fb7fc74cb2e3a778d2418f46b770
-rw-r--r--src/common/oml.c8
1 files changed, 2 insertions, 6 deletions
diff --git a/src/common/oml.c b/src/common/oml.c
index 63643c5..67eb6d8 100644
--- a/src/common/oml.c
+++ b/src/common/oml.c
@@ -141,6 +141,8 @@ int oml_mo_send_msg(const struct gsm_abis_mo *mo, struct msgb *msg, uint8_t msg_
/* FIXME: This assumption may not always be correct */
msg->trx = mo->bts->c0;
+ DEBUGPFOH(DOML, foh, "Tx %s\n", get_value_string(abis_nm_msgtype_names, foh->msg_type));
+
return oml_send_msg(msg, 0);
}
@@ -277,8 +279,6 @@ static int oml_tx_attr_resp(const struct gsm_abis_mo *mo,
const char *mo_name = gsm_abis_mo_name(mo);
int rc;
- LOGP(DOML, LOGL_INFO, "%s Tx Get Attribute Response\n", mo_name);
-
if (!nmsg)
return -NM_NACK_CANT_PERFORM;
@@ -314,8 +314,6 @@ int oml_tx_state_changed(const struct gsm_abis_mo *mo)
{
struct msgb *nmsg;
- LOGP(DOML, LOGL_INFO, "%s Tx STATE CHG REP\n", gsm_abis_mo_name(mo));
-
nmsg = oml_msgb_alloc();
if (!nmsg)
return -ENOMEM;
@@ -470,8 +468,6 @@ int oml_mo_tx_sw_act_rep(const struct gsm_abis_mo *mo)
{
struct msgb *nmsg;
- LOGP(DOML, LOGL_INFO, "%s Tx SW ACT REP\n", gsm_abis_mo_name(mo));
-
nmsg = oml_msgb_alloc();
if (!nmsg)
return -ENOMEM;