From cdfd687af4bef1c04c1b7ddc4d3f7810bec06508 Mon Sep 17 00:00:00 2001 From: Alexander Couzens Date: Wed, 9 Sep 2020 23:00:20 +0200 Subject: gsm_data: always set spare bits in channel description The spare bits were never encoded even when the spec says it must be 00. Most caller of _chan_desc_fill_tail() initialized the struct with memset(), but not all. The SI4 did not initialize it. Change-Id: Ib03d6d2cdadc49e49aa94917d17f81ef3c83f11c --- src/osmo-bsc/gsm_data.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/osmo-bsc/gsm_data.c b/src/osmo-bsc/gsm_data.c index c0c8cf6e1..fbc2ae213 100644 --- a/src/osmo-bsc/gsm_data.c +++ b/src/osmo-bsc/gsm_data.c @@ -601,6 +601,7 @@ static void _chan_desc_fill_tail(struct gsm48_chan_desc *cd, const struct gsm_lc uint16_t arfcn = lchan->ts->trx->arfcn & 0x3ff; cd->h0.tsc = gsm_ts_tsc(lchan->ts); cd->h0.h = 0; + cd->h0.spare = 0; cd->h0.arfcn_high = arfcn >> 8; cd->h0.arfcn_low = arfcn & 0xff; } else { -- cgit v1.2.3