From beb4af6ff80cbd3537878c05e39cbf957f485e9b Mon Sep 17 00:00:00 2001 From: Oliver Smith Date: Wed, 11 Mar 2020 11:03:40 +0100 Subject: osmo-bsc/bsc_vty: set default gprs cell bvci to 2 Do not use 0 as default, as it is reserved for signalling. Related: OS#4408 Change-Id: I499272f16aadd89f3bdb5d749e3e4f9e07056c15 --- src/osmo-bsc/gsm_data.c | 3 +++ tests/gprs_bvci_default.vty | 13 +++++++++++++ 2 files changed, 16 insertions(+) create mode 100644 tests/gprs_bvci_default.vty diff --git a/src/osmo-bsc/gsm_data.c b/src/osmo-bsc/gsm_data.c index 90172dd7c..f12b0324d 100644 --- a/src/osmo-bsc/gsm_data.c +++ b/src/osmo-bsc/gsm_data.c @@ -807,6 +807,9 @@ struct gsm_bts *gsm_bts_alloc(struct gsm_network *net, uint8_t bts_num) memcpy(&bts->gprs.cell.rlc_cfg, &rlc_cfg_default, sizeof(bts->gprs.cell.rlc_cfg)); + /* 3GPP TS 08.18, chapter 5.4.1: 0 is reserved for signalling */ + bts->gprs.cell.bvci = 2; + /* init statistics */ bts->bts_ctrs = rate_ctr_group_alloc(bts, &bts_ctrg_desc, bts->nr); if (!bts->bts_ctrs) { diff --git a/tests/gprs_bvci_default.vty b/tests/gprs_bvci_default.vty new file mode 100644 index 000000000..4bd95ce39 --- /dev/null +++ b/tests/gprs_bvci_default.vty @@ -0,0 +1,13 @@ +OsmoBSC> enable +OsmoBSC# configure terminal +OsmoBSC(config)# network +OsmoBSC(config-net)# bts 0 +OsmoBSC(config-net-bts)# gprs mode gprs +OsmoBSC(config-net-bts)# exit + +OsmoBSC(config-net)# show running-config +... + bts 0 +... + gprs cell bvci 2 +... -- cgit v1.2.3