From 9d2375407eeb130f291f8e17dc087fe167b4f0fc Mon Sep 17 00:00:00 2001 From: Sylvain Munaut Date: Tue, 5 May 2020 20:32:50 +0200 Subject: om2k: Fix TS channel config payload for non-superchannel case * In superchannel mode, those 3 are required. * In normal mode, "Config Type" is optional and the two others are forbidden. Signed-off-by: Sylvain Munaut Change-Id: If02d02c067ae8af8ce693ddfb8747212f3f4e441 --- src/osmo-bsc/abis_om2000.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/osmo-bsc/abis_om2000.c b/src/osmo-bsc/abis_om2000.c index d5eb24a2c..355389ba3 100644 --- a/src/osmo-bsc/abis_om2000.c +++ b/src/osmo-bsc/abis_om2000.c @@ -1479,10 +1479,14 @@ int abis_om2k_tx_ts_conf_req(struct gsm_bts_trx_ts *ts) msgb_tv_put(msg, OM2K_DEI_LSC_FILT_TIME, 10); /* units of 100ms */ msgb_tv_put(msg, OM2K_DEI_CALL_SUPV_TIME, 8); msgb_tv_put(msg, OM2K_DEI_ENCR_ALG, 0x00); - /* Not sure what those below mean */ - msgb_tv_put(msg, 0x9e, 0x00); - msgb_tv_put(msg, 0x9f, 0x37); - msgb_tv_put(msg, 0xa0, 0x01); + + /* Those are only use for superchannel */ + if (ts->trx->bts->rbs2000.use_superchannel) { + msgb_tv_put(msg, OM2K_DEI_CONFIG_TYPE, 0x00); /* 1-bit, lsb */ + msgb_tv_put(msg, OM2K_DEI_JITTER_SIZE, 0x37); + msgb_tv_put(msg, OM2K_DEI_PACKING_ALGO, 0x01); + } + break; } -- cgit v1.2.3