From 8d4faf10cd09995f4160a551436bce0611facbeb Mon Sep 17 00:00:00 2001 From: Neels Hofmeyr Date: Wed, 29 Aug 2018 13:58:41 +0200 Subject: cosmetic: lchan activ: no need to clear mr again In lchan state UNUSED, on activating an lchan, we zero out the lchan->mr_ms_lv and mr_bts_lv. However, in UNUSED's onenter function, we already called lchan_reset(), clearing out the lchan completely. Drop two lines of unnecessary code. Change-Id: I8b38f222f1c8c822e8e5e776850dbc60e30e8b8d --- src/osmo-bsc/lchan_fsm.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/osmo-bsc/lchan_fsm.c b/src/osmo-bsc/lchan_fsm.c index 13ae7ad6d..28dc846ab 100644 --- a/src/osmo-bsc/lchan_fsm.c +++ b/src/osmo-bsc/lchan_fsm.c @@ -460,8 +460,6 @@ static void lchan_fsm_unused(struct osmo_fsm_inst *fi, uint32_t event, void *dat }; lchan->ms_power = ms_pwr_ctl_lvl(bts->band, bts->ms_max_power); lchan->bs_power = 0; /* 0dB reduction, output power = Pn */ - memset(&lchan->mr_ms_lv, 0, sizeof(lchan->mr_ms_lv)); - memset(&lchan->mr_bts_lv, 0, sizeof(lchan->mr_bts_lv)); } if (info->chan_mode == GSM48_CMODE_SPEECH_AMR) -- cgit v1.2.3