From 60f08b57efcf0cb0747079cc04c4765a1ad27cdc Mon Sep 17 00:00:00 2001 From: Harald Welte Date: Sun, 21 Oct 2018 13:37:59 +0200 Subject: ipaccess-config: Fix open() return value checking open() returning 0 is valid, but negative values indicate errors. Change-Id: Id7e62116bfee550ef9906e78a0fce6f28af27a97 Fixes: Coverity CID#57865 --- src/ipaccess/ipaccess-config.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ipaccess/ipaccess-config.c b/src/ipaccess/ipaccess-config.c index 079bae2b9..549170095 100644 --- a/src/ipaccess/ipaccess-config.c +++ b/src/ipaccess/ipaccess-config.c @@ -634,7 +634,7 @@ static int find_sw_load_params(const char *filename) INIT_LLIST_HEAD(entry); fd = open(filename, O_RDONLY); - if (!fd) { + if (fd < 0) { perror("nada"); return -1; } @@ -729,7 +729,7 @@ static void analyze_firmware(const char *filename) printf("Opening possible firmware '%s'\n", filename); fd = open(filename, O_RDONLY); - if (!fd) { + if (fd < 0) { perror("nada"); return; } -- cgit v1.2.3