From 60b6fdb20c92ab5557e1dcebcdf8c527b3b0d052 Mon Sep 17 00:00:00 2001 From: Vadim Yanitskiy Date: Fri, 23 Aug 2019 16:37:38 +0200 Subject: abis_nm.c: use LOGP() macro instead of LOGPC() The LOGPC() is usually used for continuation when printing complex logging messages (e.g. where using format string is not enough). In this case, nothing is being printed before calling LOGPC(), so the logging messages appear without the meta info (time-stamp, level, category, etc.), for example: BTS 0 reported connected PCU version 0.7.0.1-2585-dirty Change-Id: I868633ad3e50f2cb3ebfb2c566d16c4710f17563 --- src/osmo-bsc/abis_nm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/osmo-bsc/abis_nm.c b/src/osmo-bsc/abis_nm.c index 7d059b5d1..48e918353 100644 --- a/src/osmo-bsc/abis_nm.c +++ b/src/osmo-bsc/abis_nm.c @@ -311,7 +311,7 @@ static inline void log_oml_fail_rep(const struct gsm_bts *bts, const char *type, enum abis_nm_pcause_type pcause = p_val[0]; enum abis_mm_event_causes cause = osmo_load16be(p_val + 1); - LOGPC(DNM, LOGL_ERROR, "BTS %u: Failure Event Report: ", bts->nr); + LOGP(DNM, LOGL_ERROR, "BTS %u: Failure Event Report: ", bts->nr); if (type) LOGPC(DNM, LOGL_ERROR, "Type=%s, ", type); if (severity) @@ -341,10 +341,10 @@ static inline void handle_manufact_report(struct gsm_bts *bts, const uint8_t *p_ switch (cause) { case OSMO_EVT_PCU_VERS: if (text) { - LOGPC(DNM, LOGL_NOTICE, "BTS %u reported connected PCU version %s\n", bts->nr, text); + LOGP(DNM, LOGL_NOTICE, "BTS %u reported connected PCU version %s\n", bts->nr, text); osmo_strlcpy(bts->pcu_version, text, sizeof(bts->pcu_version)); } else { - LOGPC(DNM, LOGL_ERROR, "BTS %u reported PCU disconnection.\n", bts->nr); + LOGP(DNM, LOGL_ERROR, "BTS %u reported PCU disconnection.\n", bts->nr); bts->pcu_version[0] = '\0'; } break; -- cgit v1.2.3