From 052ab5ed3f5e28975111f4e09f6ed361ed7de23e Mon Sep 17 00:00:00 2001 From: Harald Welte Date: Sat, 25 May 2019 09:38:17 +0200 Subject: rx_fail_evt_rep(): Don't recycle variable the 'p_val' variable should represent he 'probabl cause value' and nothing else. Let's use other local variables for other things. Change-Id: Ie79279fc1d42cd57e7478820493b250fe38c2f4f --- src/osmo-bsc/abis_nm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/osmo-bsc/abis_nm.c b/src/osmo-bsc/abis_nm.c index 240517bcb..bff6c1258 100644 --- a/src/osmo-bsc/abis_nm.c +++ b/src/osmo-bsc/abis_nm.c @@ -368,8 +368,8 @@ static int rx_fail_evt_rep(struct msgb *mb, struct gsm_bts *bts) oh->length-sizeof(*foh)); if (TLVP_PRESENT(&tp, NM_ATT_ADD_TEXT)) { - p_val = TLVP_VAL(&tp, NM_ATT_ADD_TEXT); - p_text = talloc_strndup(tall_bsc_ctx, (const char *) p_val, + const uint8_t *val = TLVP_VAL(&tp, NM_ATT_ADD_TEXT); + p_text = talloc_strndup(tall_bsc_ctx, (const char *) val, TLVP_LEN(&tp, NM_ATT_ADD_TEXT)); } -- cgit v1.2.3