From 01a3c2689c706d3da48d525b535b92510a43cf9b Mon Sep 17 00:00:00 2001 From: Harald Welte Date: Wed, 4 Dec 2019 14:47:21 +0100 Subject: gsm_04_80: Avoid using deprecated API MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit gsm_04_80_utils.c: In function ‘bsc_send_ussd_release_complete’: gsm_04_80_utils.c:37:9: warning: ‘gsm0480_create_ussd_release_complete’ is deprecated: Use gsm0480_create_release_complete() instead. [-Wdeprecated-declarations] 37 | struct msgb *msg = gsm0480_create_ussd_release_complete(); | ^~~~ CC gsm_data.o In file included from gsm_04_80_utils.c:22: /usr/local/include/osmocom/gsm/gsm0480.h:120:14: note: declared here 120 | struct msgb *gsm0480_create_ussd_release_complete(void) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ The commit is not changing the existing logic/assumption: TID 0 should not be in use by anything else at the point the USSD is generated. Change-Id: I739158dec62cd5f0c2080fbb426af9c024baef87 --- src/osmo-bsc/gsm_04_80_utils.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/osmo-bsc/gsm_04_80_utils.c b/src/osmo-bsc/gsm_04_80_utils.c index 8de1262e9..5ac022689 100644 --- a/src/osmo-bsc/gsm_04_80_utils.c +++ b/src/osmo-bsc/gsm_04_80_utils.c @@ -34,7 +34,8 @@ int bsc_send_ussd_notify(struct gsm_subscriber_connection *conn, int level, int bsc_send_ussd_release_complete(struct gsm_subscriber_connection *conn) { - struct msgb *msg = gsm0480_create_ussd_release_complete(); + /* ugly: we obviously don't know if TID 0 is currently in user for the given subscriber... */ + struct msgb *msg = gsm0480_create_release_complete(0); if (!msg) return -1; gscon_submit_rsl_dtap(conn, msg, 0, 0); -- cgit v1.2.3