path: root/include/osmocom/bsc/gsm_data.h
diff options
authorNeels Hofmeyr <neels@hofmeyr.de>2018-11-06 22:24:07 +0100
committerNeels Hofmeyr <neels@hofmeyr.de>2018-11-12 16:34:08 +0100
commit76e8e3d623aa2e6d742f65a9986e74fbf7ba2b0a (patch)
treeec73d9f7fd59ad594573e9def7e8a7b5c7687bcf /include/osmocom/bsc/gsm_data.h
parentcda317f842f838666daed0e984f27b172b3fc444 (diff)
lchan release: always Deact SACCH
If an lchan is being released and had a SACCH active, there is no reason to omit the Deact SACCH message ever. All of the callers that passed do_deact_sachh = false did so for no good reason. Drop the do_deact_sachh flag everywhere and, when the lchan type matches and SAPI[0] is still active, simply always send a Deact SACCH message. The do_deact_sachh flag was carried over from legacy code, by me, mainly because I never really understood why it was there. I do hope I'm correct now, asserting that having this flag makes no sense. Change-Id: Id3301df059582da2377ef82feae554e94fa42035
Diffstat (limited to 'include/osmocom/bsc/gsm_data.h')
1 files changed, 0 insertions, 1 deletions
diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h
index 5805a5f0c..3712b9778 100644
--- a/include/osmocom/bsc/gsm_data.h
+++ b/include/osmocom/bsc/gsm_data.h
@@ -513,7 +513,6 @@ struct gsm_lchan {
/* If an event to release the lchan comes in while still waiting for responses, just mark this
* flag, so that the lchan will gracefully release at the next sensible junction. */
bool release_requested;
- bool deact_sacch;
bool do_rr_release;
char *last_error;