aboutsummaryrefslogtreecommitdiffstats
path: root/Makefile.am
diff options
context:
space:
mode:
authorVadim Yanitskiy <vyanitskiy@sysmocom.de>2021-01-14 03:31:29 +0100
committerfixeria <vyanitskiy@sysmocom.de>2021-01-14 20:47:09 +0000
commit259e797a8abed7bbf5de502d0eaa4634ce1bf5cd (patch)
tree6509d5a3012a56216b7953fb31c531df34728bc2 /Makefile.am
parentf5c8034bb71220158ce4b37d1f7d81b2c15ff002 (diff)
vty: fix 'codec-list' command: check all given arguments firstHEADmaster
Allocating a new list of supported codecs *before* checking the command arguments is a bad idea. The operator may simply mistype one of the codecs and will end up with a list of NULL pointers. The functions calling audio_support_to_gsm88() assume that this list always does contain valid pointers, so if a new subscriber connection gets established, or the operator simply invokes 'show running-config', osmo-bsc would crash due to NULL pointer dereference. Steps to reproduce: 1. In the VTY, do: 'en' -> 'configure terminal' -> 'msc'; 2. Configure any invalid codec list, e.g. 'codec-list Boom!'; 3. Invoke 'show running-config', boom! Let's check the input before changing the internal structures. Change-Id: I35b740a39c9cf3716d286e717486ef505bc61522 Fixes: OS#4946
Diffstat (limited to 'Makefile.am')
0 files changed, 0 insertions, 0 deletions