aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNeels Hofmeyr <neels@hofmeyr.de>2019-07-11 03:43:34 +0200
committerNeels Hofmeyr <neels@hofmeyr.de>2019-07-13 05:07:53 +0200
commit08822a33020b3e297058e87c0fa95c4a4cbfe8c6 (patch)
treea6556421e7011c70130702b159fe3f26864048a1
parent14c80fdb65671615cbb44329bae9f57a4e6d68d7 (diff)
comment and VTY doc tweaks
Clarify some in-code comments. Fix descriptions of some handover timers, which still talked of "MO" and "MT" handover -- which we now call "inter-BSC out" or "inter-BSC in" instead. Change-Id: I8429a830edd0325893ac90f22fcc05309617bd2d
-rw-r--r--include/osmocom/bsc/gsm_data.h2
-rw-r--r--src/osmo-bsc/handover_fsm.c3
-rw-r--r--src/osmo-bsc/net_init.c6
3 files changed, 6 insertions, 5 deletions
diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h
index a464001..d82d1ba 100644
--- a/include/osmocom/bsc/gsm_data.h
+++ b/include/osmocom/bsc/gsm_data.h
@@ -1505,7 +1505,7 @@ struct gsm_network {
struct llist_head bts_list;
struct llist_head bts_rejected;
- /* shall reference gsm_network_T[] */
+ /* see gsm_network_T_defs */
struct osmo_tdef *T_defs;
enum gsm_chan_t ctype_by_chreq[_NUM_CHREQ_T];
diff --git a/src/osmo-bsc/handover_fsm.c b/src/osmo-bsc/handover_fsm.c
index 22618c5..7406a97 100644
--- a/src/osmo-bsc/handover_fsm.c
+++ b/src/osmo-bsc/handover_fsm.c
@@ -200,7 +200,8 @@ void handover_request(struct handover_out_req *req)
conn = req->old_lchan->conn;
OSMO_ASSERT(conn && conn->fi);
- /* To make sure we're allowed to start a handover, go through a gscon event dispatch. */
+ /* To make sure we're allowed to start a handover, go through a gscon event dispatch. If that is accepted, the
+ * same req is passed to handover_start(). */
osmo_fsm_inst_dispatch(conn->fi, GSCON_EV_HANDOVER_START, req);
}
diff --git a/src/osmo-bsc/net_init.c b/src/osmo-bsc/net_init.c
index 1ef9bd5..34403fa 100644
--- a/src/osmo-bsc/net_init.c
+++ b/src/osmo-bsc/net_init.c
@@ -26,10 +26,10 @@
#include <osmocom/bsc/neighbor_ident.h>
static struct osmo_tdef gsm_network_T_defs[] = {
- { .T=7, .default_val=10, .desc="inter-BSC Handover MO, HO Required to HO Command" },
- { .T=8, .default_val=10, .desc="inter-BSC Handover MO, HO Command to final Clear" },
+ { .T=7, .default_val=10, .desc="inter-BSC/MSC Handover outgoing, BSSMAP HO Required to HO Command timeout" },
+ { .T=8, .default_val=10, .desc="inter-BSC/MSC Handover outgoing, BSSMAP HO Command to final Clear timeout" },
{ .T=10, .default_val=6, .desc="RR Assignment" },
- { .T=101, .default_val=10, .desc="inter-BSC Handover MT, HO Request to HO Accept" },
+ { .T=101, .default_val=10, .desc="inter-BSC/MSC Handover incoming, BSSMAP HO Request to HO Accept" },
{ .T=3101, .default_val=3, .desc="RR Immediate Assignment" },
{ .T=3103, .default_val=5, .desc="Handover" },
{ .T=3105, .default_val=100, .unit=OSMO_TDEF_MS, .desc="Physical Information" },