From c962d45669ca5003952d36c6c0c94167f5b2f504 Mon Sep 17 00:00:00 2001 From: Holger Hans Peter Freyther Date: Sun, 14 Jul 2013 08:58:15 +0200 Subject: smpp: Add the classic check for osmo_fd_register In case the osmo_fd_register will fail we will need to free the memory we have allocated. Fixes: Coverity CID 1042375 --- openbsc/src/libmsc/smpp_smsc.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/openbsc/src/libmsc/smpp_smsc.c b/openbsc/src/libmsc/smpp_smsc.c index 6acd52ac5..2b17d1230 100644 --- a/openbsc/src/libmsc/smpp_smsc.c +++ b/openbsc/src/libmsc/smpp_smsc.c @@ -878,7 +878,11 @@ static int link_accept_cb(struct smsc *smsc, int fd, esme->wqueue.bfd.fd = fd; esme->wqueue.bfd.data = esme; esme->wqueue.bfd.when = BSC_FD_READ; - osmo_fd_register(&esme->wqueue.bfd); + + if (osmo_fd_register(&esme->wqueue.bfd) != 0) { + talloc_free(esme); + return -EIO; + } esme->wqueue.read_cb = esme_link_read_cb; esme->wqueue.write_cb = esme_link_write_cb; -- cgit v1.2.3