From c9251fa8c9e3bc6ea2ea9182e0f1b13b16f065ca Mon Sep 17 00:00:00 2001 From: Holger Hans Peter Freyther Date: Sun, 14 Jul 2013 08:47:06 +0200 Subject: ipaccess: The proxy code checked the array but not the element Array compared against 0 (NO_EFFECT) array_null: Comparing an array to null is not useful: "ipbc->bsc_rsl_conn". Fixes: Coverity CID 1040718 --- openbsc/src/ipaccess/ipaccess-proxy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/openbsc/src/ipaccess/ipaccess-proxy.c b/openbsc/src/ipaccess/ipaccess-proxy.c index 0f03e4e89..9ab4ebbf4 100644 --- a/openbsc/src/ipaccess/ipaccess-proxy.c +++ b/openbsc/src/ipaccess/ipaccess-proxy.c @@ -647,7 +647,7 @@ static void reconn_tmr_cb(void *data) logp_ipbc_uid(DLINP, LOGL_NOTICE, ipbc, priv_nr >> 8); LOGPC(DLINP, LOGL_NOTICE, "RSL Trying to reconnect\n"); ipbc->bsc_rsl_conn[i] = connect_bsc(&sin, priv_nr, ipbc); - if (!ipbc->bsc_rsl_conn) + if (!ipbc->bsc_rsl_conn[i]) goto reschedule; logp_ipbc_uid(DLINP, LOGL_NOTICE, ipbc, priv_nr >> 8); LOGPC(DLINP, LOGL_NOTICE, "RSL Reconnected\n"); -- cgit v1.2.3