From 096dc3a466d41b294578b4aa0a48e621efc5bcec Mon Sep 17 00:00:00 2001 From: Holger Hans Peter Freyther Date: Fri, 5 Jul 2013 08:21:38 +0200 Subject: nat: The con variable is not assigned at this point Coverity pointed out that this code is logically dead. Quickly judging the code we will forward the RSLD message anyway. Remove the code for now and next time I work on the NAT/USSD bridge I will have a look at the flow of the RLSD messages. Fixes: Coverity CID 1042327 --- openbsc/src/osmo-bsc_nat/bsc_nat.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/openbsc/src/osmo-bsc_nat/bsc_nat.c b/openbsc/src/osmo-bsc_nat/bsc_nat.c index 27ac74766..12373397d 100644 --- a/openbsc/src/osmo-bsc_nat/bsc_nat.c +++ b/openbsc/src/osmo-bsc_nat/bsc_nat.c @@ -667,11 +667,6 @@ static int forward_sccp_to_bts(struct bsc_msc_connection *msc_con, struct msgb * goto send_to_all; break; case SCCP_MSG_TYPE_RLSD: - if (con && con->con_local == NAT_CON_END_USSD) { - LOGP(DNAT, LOGL_NOTICE, "RLSD for a USSD connection. Ignoring.\n"); - con = NULL; - } - /* fall through */ case SCCP_MSG_TYPE_CREF: case SCCP_MSG_TYPE_DT1: case SCCP_MSG_TYPE_IT: -- cgit v1.2.3