From 2e1a3a982a048765ffe29437ecb85e93cd13330b Mon Sep 17 00:00:00 2001 From: Alexander Couzens Date: Wed, 27 Jan 2021 20:44:41 +0100 Subject: gprs_ns2: remove api call gprs_ns2_dynamic_create_nse The call was only introduced as workaround for the first implementation of vty. There is no need for this anymore. The configuration can just add "accept-ipaccess" to the bind to allow creation of dynamic ipaccess NSE. Change-Id: Ie924ead6da17657f3da334068c8ada82c8845495 --- src/gb/gprs_ns2.c | 14 +------------- src/gb/gprs_ns2_internal.h | 3 --- src/gb/libosmogb.map | 1 - 3 files changed, 1 insertion(+), 17 deletions(-) (limited to 'src') diff --git a/src/gb/gprs_ns2.c b/src/gb/gprs_ns2.c index 7e273fb6..be355134 100644 --- a/src/gb/gprs_ns2.c +++ b/src/gb/gprs_ns2.c @@ -874,7 +874,7 @@ enum ns2_cs ns2_create_vc(struct gprs_ns2_vc_bind *bind, if (bind->ll != GPRS_NS2_LL_UDP || dialect != GPRS_NS2_DIALECT_IPACCESS) return NS2_CS_SKIPPED; - if (!bind->nsi->create_nse || !bind->accept_ipaccess) + if (!bind->accept_ipaccess) return NS2_CS_SKIPPED; nse = gprs_ns2_create_nse(bind->nsi, nsei, bind->ll, dialect); @@ -1208,18 +1208,6 @@ void gprs_ns2_free(struct gprs_ns2_inst *nsi) talloc_free(nsi); } -/*! Configure whether a NS Instance should dynamically create NSEs based on incoming traffic. - * \param nsi the instance to modify - * \param create_nse if NSE can be created on receiving package. SGSN set this. - * \return 0 on success; negative on error - */ -int gprs_ns2_dynamic_create_nse(struct gprs_ns2_inst *nsi, bool create_nse) -{ - nsi->create_nse = create_nse; - - return 0; -} - /*! Start the NS-ALIVE FSM in all NS-VCs of given NSE. * \param[in] nse NS Entity in whihc to start NS-ALIVE FSMs */ void gprs_ns2_start_alive_all_nsvcs(struct gprs_ns2_nse *nse) diff --git a/src/gb/gprs_ns2_internal.h b/src/gb/gprs_ns2_internal.h index 027071d9..0574cb2b 100644 --- a/src/gb/gprs_ns2_internal.h +++ b/src/gb/gprs_ns2_internal.h @@ -108,9 +108,6 @@ struct gprs_ns2_inst { /*! linked lists of all NSVC in this instance */ struct llist_head nse; - /*! create dynamic NSE on receiving packages */ - bool create_nse; - uint16_t timeout[NS_TIMERS_COUNT]; /*! workaround for rate counter until rate counter accepts char str as index */ diff --git a/src/gb/libosmogb.map b/src/gb/libosmogb.map index fa05b97a..71be117d 100644 --- a/src/gb/libosmogb.map +++ b/src/gb/libosmogb.map @@ -137,7 +137,6 @@ gprs_ns2_aff_cause_prim_strs; gprs_ns2_bind_by_name; gprs_ns2_cause_strs; gprs_ns2_create_nse; -gprs_ns2_dynamic_create_nse; gprs_ns2_find_vc_by_sockaddr; gprs_ns2_free; gprs_ns2_free_bind; -- cgit v1.2.3