From f8e153d815ead9bd11665d0270c439ab5c5f568b Mon Sep 17 00:00:00 2001 From: Vadim Yanitskiy Date: Sun, 31 May 2020 16:06:36 +0700 Subject: bts_features: fix: properly check the result of bitvec_get_bit_pos() If a feature index does not fit to the feature vector, this function would return a negative number that would be casted to true. This is wrong, we should return false instead. Change-Id: Id1ad92e7654a806bb920ae9507c88a122e8d09f0 --- include/osmocom/gsm/bts_features.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/osmocom/gsm/bts_features.h b/include/osmocom/gsm/bts_features.h index 7ead0203..6ab8f622 100644 --- a/include/osmocom/gsm/bts_features.h +++ b/include/osmocom/gsm/bts_features.h @@ -40,5 +40,5 @@ static inline int osmo_bts_set_feature(struct bitvec *features, enum osmo_bts_fe static inline bool osmo_bts_has_feature(const struct bitvec *features, enum osmo_bts_features feature) { OSMO_ASSERT(_NUM_BTS_FEAT < MAX_BTS_FEATURES); - return bitvec_get_bit_pos(features, feature); + return bitvec_get_bit_pos(features, feature) == ONE; } -- cgit v1.2.3