From a08edff80c02a79cbbe53b27d3a17ae587f633ba Mon Sep 17 00:00:00 2001 From: Vadim Yanitskiy Date: Sun, 16 Jun 2019 01:00:27 +0700 Subject: Revert "fsm.c: Print error message for FSM with allstate_action but no events" This reverts commit b3f94eb39e19366c3458643ee329a73155d46ff8, that unfortunately breaks some projects which call osmo_fsm_register() on DSO load (i.e. using __attribute__((constructor))) before the logging is initialized. Change-Id: Idc6fcce7e946c23d48589b920e309d60aa7b6645 --- src/fsm.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/src/fsm.c b/src/fsm.c index 04c583b0..337786d9 100644 --- a/src/fsm.c +++ b/src/fsm.c @@ -256,17 +256,6 @@ int osmo_fsm_register(struct osmo_fsm *fsm) return -EEXIST; if (fsm->event_names == NULL) LOGP(DLGLOBAL, LOGL_ERROR, "FSM '%s' has no event names! Please fix!\n", fsm->name); - - if (fsm->allstate_action && !fsm->allstate_event_mask) { - LOGP(DLGLOBAL, LOGL_ERROR, "FSM '%s' has allstate_action but no allstate_event_mask\n", - fsm->name); - } - - if (!fsm->allstate_action && fsm->allstate_event_mask) { - LOGP(DLGLOBAL, LOGL_ERROR, "FSM '%s' has allstate_event_mask but no allstate_action\n", - fsm->name); - } - llist_add_tail(&fsm->list, &osmo_g_fsms); INIT_LLIST_HEAD(&fsm->instances); -- cgit v1.2.3