From 50059bb64f64f3d7842d9edd454433d9e5fd8b36 Mon Sep 17 00:00:00 2001 From: Holger Hans Peter Freyther Date: Thu, 15 May 2014 15:45:55 +0200 Subject: ctrl: Remove the param parameter as it was never used/implemented --- openbsc/include/openbsc/control_cmd.h | 4 ---- openbsc/src/libctrl/control_cmd.c | 2 -- 2 files changed, 6 deletions(-) diff --git a/openbsc/include/openbsc/control_cmd.h b/openbsc/include/openbsc/control_cmd.h index a87c469a..47928698 100644 --- a/openbsc/include/openbsc/control_cmd.h +++ b/openbsc/include/openbsc/control_cmd.h @@ -66,7 +66,6 @@ struct ctrl_cmd_struct { struct ctrl_cmd_element { const char *name; - const char *param; struct ctrl_cmd_struct strcmd; int (*set)(struct ctrl_cmd *cmd, void *data); int (*get)(struct ctrl_cmd *cmd, void *data); @@ -125,7 +124,6 @@ static int verify_##cmdname(struct ctrl_cmd *cmd, const char *value, void *_data CTRL_HELPER_VERIFY_RANGE(cmdname, min, max) \ static struct ctrl_cmd_element cmd_##cmdname = { \ .name = cmdstr, \ - .param = NULL, \ .get = &get_##cmdname, \ .set = &set_##cmdname, \ .verify = &verify_##cmdname, \ @@ -154,7 +152,6 @@ static int set_##cmdname(struct ctrl_cmd *cmd, void *_data) \ CTRL_HELPER_SET_STRING(cmdname, dtype, element) \ static struct ctrl_cmd_element cmd_##cmdname = { \ .name = cmdstr, \ - .param = NULL, \ .get = &get_##cmdname, \ .set = &set_##cmdname, \ .verify = NULL, \ @@ -166,7 +163,6 @@ static int set_##cmdname(struct ctrl_cmd *cmd, void *data); \ static int verify_##cmdname(struct ctrl_cmd *cmd, const char *value, void *data); \ static struct ctrl_cmd_element cmd_##cmdname = { \ .name = cmdstr, \ - .param = NULL, \ .get = &get_##cmdname, \ .set = &set_##cmdname, \ .verify = &verify_##cmdname, \ diff --git a/openbsc/src/libctrl/control_cmd.c b/openbsc/src/libctrl/control_cmd.c index 3c4efc06..db88668f 100644 --- a/openbsc/src/libctrl/control_cmd.c +++ b/openbsc/src/libctrl/control_cmd.c @@ -142,8 +142,6 @@ int ctrl_cmd_exec(vector vline, struct ctrl_cmd *command, vector node, void *dat command->reply = "Value failed verification."; goto out; } - } else if (cmd_el->param) { - LOGP(DCTRL, LOGL_NOTICE, "Parameter verification unimplemented, continuing without\n"); } ret = cmd_el->set(command, data); goto out; -- cgit v1.2.3