aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2014-03-18msgb: Enable checking and fix breaking code (TODO)jerlbeck/msgb-validationJacob Erlbeck1-1/+1
Sponsored-by: On-Waves ehf
2014-03-18msgb/test: Add test for msgb message buffersJacob Erlbeck4-2/+154
This tests several API functions of the msgb by checking the invariant and by dumping resulting message buffers as hex. Sponsored-by: On-Waves ehf
2014-03-18msgb: Let msgb_hexdump be more tolerantJacob Erlbeck1-7/+39
This patch makes msgb_hexdump accept out of range lXh pointers and shows info about them instead of aborting the dump entirely. Sponsored-by: On-Waves ehf
2014-03-18msgb: Add msgb_pull_to function (TODO)Jacob Erlbeck1-0/+24
This function advances msg->data to a given pointer and resets all lXh pointer that would point before the new value. Sponsored-by: On-Waves ehf
2014-03-18msgb: Check msgb consistencyJacob Erlbeck2-4/+81
This adds a function that verifies whether a mgsb is consistent. Macros are provided that check optionally if msgbs passed as arguments to macros and functions are consistent and call MSGB_ABORT if not. The MSGB_ENABLE_CHECKS macro controls at how many places this is done: 0: no checks, 1: in a few places (not in getters), 2: everywhere Sponsored-by: On-Waves ehf
2014-03-18msgb: Optionally declare some msgb struct fields as constJacob Erlbeck4-33/+59
Writing directly to following struct fields may cause inconsistencies that are hard to debug: data_len, len, head, tail, data In general, the available macros and functions should be used to modify them instead. This patch declares these fields as const if MSGB_DISABLE_DIRECT_WRITE is defined. Doing so may lead to warnings and errors, therefore this macro is only defined for libosmocore yet, where at least the errors are also fixed by this patch. The main purpose is to maintain consistency, so only modifing the fields themselves is restricted. It's still possible to modify the data the pointers refer to. Sponsored-by: On-Waves ehf
2014-03-16lapd: Improve log message and mention the SAPI the dl is onHolger Hans Peter Freyther1-2/+2
When debugging an issue that involves SAPI=0 and SAPI=3 the log file does not have enough context. Add the SAPI to this message so we at least understand which SAPI we are talking about.
2014-03-12sms: Fix typo in a macros name: GSM340_SMS_RESSERVED -> GSM340_SMS_RESERVED.Alexander Chemeris1-1/+1
2014-03-10Merge branch 'jerlbeck/fixes/ladp-sms'Holger Hans Peter Freyther5-59/+165
2014-03-10ladpm: Fix msgb handling and SAPI=3 establishment delayJacob Erlbeck3-31/+33
Currently it takes 3s to establish a SAPI 3 SACCH connection with osmo-bts. This is due to the fact, that a broken SABME request is sent first and and is ignored by the MS. Then, after a T200 timeout (2s) the SABME command is sent again (this time correctly) and answered by the MS. The first SABME message is broken (it has a length field of 3 and ends with 3 bytes from the tail of the original RSL message), because of it is expected throughout lapdm.c that msg buffers containing RSL have msg->l2h == msg->data. Some abis input drivers fulfill this but IPA doesn't, thus the 3 bytes of the IPA header are still part of the msg and confuse length computation. Since internal fields of the msg are modified directly, this is difficult to see. This patch adds a new function msgb_pull_to_l3() that explicitely skips over all headers prepending L3 and therefore resets l1h and l2h. This function is then used instead of msgb_pull_l2h() which only worked correctly when msg->l2h == msg->data. In addition, code manipulating msg->tail and msg->len directly has been replaced by calls to msgb_trim(). Note that this patch does not fix all issues of this case in the LADP related code. Ticket: SYS#192 Sponsored-by: On-Waves ehf
2014-03-04lapd/test: Check for empty ACCH queue, tooJacob Erlbeck1-0/+2
This just adds a single test to verify that the ACCH queue is actually empty. Sponsored-by: On-Waves ehf
2014-03-04lapd/test: Extend test case to test msgs having data before l2hJacob Erlbeck2-4/+16
Since e.g. the IPA input driver leaves it's specific header in front of msg->l2h, so that msg->l2h != msg->data. The lapdm code does not expect this at least in rslms_rx_rll_est_req(). This patch modifies the test program to add a dummy L1 header to generated messages (unless the test would abort when doing so). Note that the ok file reflects the current state which is not correct. Sponsored-by: On-Waves ehf
2014-03-04lapd/test: Show dequeued messagesJacob Erlbeck2-32/+72
This adds and uses a wrapper for lapdm_phsap_dequeue_prim() that prints information about the message that has been taken from the queue.
2014-03-04msgb: Add msgb_hexdump() functionJacob Erlbeck2-0/+50
This function works like osmo_hexdump() and returns a static buffer containing hex bytes along with markers for the layers. Note that it uses osmo_hexdump() internally, thus a call to msgb_hexdump() invalidates the buffer that has been returned by an earlier call to osmo_hexdump(). In short: don't mix them in a single call printf(). Sponsored-by: On-Waves ehf
2014-02-09lapd: Use the right struct for the talloc_zero_array callHolger Hans Peter Freyther1-2/+2
I saw this while playing with talloc pools and wondered why lapd_core is creating a log_info. Use the right struct for the array.
2014-02-08sms: The msg_ref is passed from the outside so remove the wrong fixmeHolger Hans Peter Freyther1-1/+1
2014-01-26lapd/test: Add test case for RSL EST REQ -> LAPDJacob Erlbeck2-15/+112
This test case processes RSL establish requests for SMS (SAPI 3) on the SDCCH and the SACCH channels. The TX queues are checked after processing each message. Ticket: SYS#192 Sponsored-by: On-Waves ehf
2014-01-23lapdm: Fix typo in the commentHolger Hans Peter Freyther1-1/+1
2014-01-20debian: Build the new upstream version of libosmocoreHolger Hans Peter Freyther1-1/+7
2014-01-13gsm/gsm48ie: Fix range 256 W[i] decoding0.6.5Jacob Erlbeck1-4/+4
Currently w[14]/w[15] and w[18]/w[19] are swapped in range 256 format decoding in gsm48_decode_freq_list(). This patch fixes this. Sponsored-by: On-Waves ehf
2014-01-09sms: Fix gsm_7bit legacy functions return valueJacob Erlbeck4-6/+44
The legacy 7bit conversion functions (those without the '_n_' in the name) gave wrong return values on 64 bit platforms due to unproper signed/unsigned conversions and the usage of SIZE_MAX. This patch fixes this by using a smaller max size (see GSM_7BIT_LEGACY_MAX_BUFFER_SIZE, currently set to 64k) for the legacy wrappers and by using unsigned int for max_septets. In addition, there are tests now that check the return values of legacy encoding and decoding. Sponsored-by: On-Waves ehf
2014-01-02abis: Use the right return value for abis_nm_pchan4chcombHolger Hans Peter Freyther2-2/+2
abis_nm_pchan4chcomb will return a pchan for a given channel combination but returned a value of the channel combination. Fix it to return the physical channel combination. Fixes: Coverity CID 1040767
2014-01-02utils: Greatly improve performance of osmo_hexdump routinesNils O. Selåsdal2-6/+14
In the osmo-bts and libosmo-abis code the hexdump routine is used for every incoming/outgoing packet (including voice frames) and the usage of snprintf showed up inside profiles. There is a semantic change when more than 4096 characters are used. The code will now truncate at byte boundaries (and not nibbles). Code: static const int lengths[] = { 23, 1000, 52 }; char buf[4096]; int i; for (i = 0; i < 30000; ++i) char *res = osmo_hexdump(buf, lengths[i & 3]); Results: before: after: real 0m3.233s real 0m0.085s user 0m3.212s user 0m0.084s sys 0m0.000s sys 0m0.000s
2014-01-02utils: Add a simple testcase for osmo_hexdumpHolger Hans Peter Freyther4-2/+64
This code makes a simple dump and tests for the corner case
2013-12-29logging: Copy the filter_fn and fix the IMSI filter in OpenBSCHolger Hans Peter Freyther2-0/+18
The filter_fn has not been copied into the new structure breaking the imsi and other filters in OpenBSC. Looking at the code we should also introduce a callback for the reset of the context so we could use subscr_get/subscr_put on the subscriber structure.
2013-12-12debian: Enable hardening options for debianHolger Hans Peter Freyther1-0/+2
2013-12-07Refactor COMP128v23 implementation and add test suitMax8-42/+4216
2013-11-22gb: Remove comment about ABI changes from the MakefileHolger Hans Peter Freyther1-3/+0
Okay. this comment thing has not worked (I totally forgot about it). I think either we try to find ABI breakages with tools or we use #error macros and check for a version...
2013-11-11debian: Update the changelogJacob Erlbeck1-1/+7
Sponsored-by: On-Waves ehf
2013-11-11gprs: Fix VTY NSVC initialisation bug by changing gprs_nsvc_create()Jacob Erlbeck1-3/+3
Currently the field nsvci_is_valid is set to 0 in the NSVC object returned by gprs_nsvc_create(). This was a semantic change probably introduced by commit 5e6d679d. As a result, NSVC created via the VTY have this flag set to 0 causing RESET_ACK messages to be rejected. This patch changes the default behaviour of gprs_nsvc_create() to always set this flag. So it must be set to 0 explicitely if needed which is more intuitive and thus less error prone. It fixes breaking connections from the Gbproxy to the SGSN. Ticket: OW#874 Sponsored-by: On-Waves ehf
2013-11-03implement COMP128 version 2 and 3 A3/A8 algorithmKevin Redon5-5/+264
simple copy into C from reversed code from www.hackingprojects.net
2013-10-30gprs: Ignore NS RESET_ACK and ALIVE_ACK without RESETJacob Erlbeck2-6/+17
Currently those messages are answered by a NS_STATUS message when received on an uninitialised (no NS_RESET hat been seen yet) NS_VC which violates GPP TS 08.16 7.3.1 and 7.4.1. This patch adds checks to gprs_ns_vc_create() and eventually returns before the error NS_STATUS message is generated. Sponsored-by: On-Waves ehf
2013-10-30grps: Add test for NS messages that shall be ignoredJacob Erlbeck2-0/+55
Several messages shall not be answered when a RESET hasn't been received on a NS-VC: - NS_RESET_ACK (see 3GPP TS 08.16, 7.3.1) - NS_ALIVE_ACK (see 3GPP TS 08.16, 7.4.1) - NS_STATUS (see 3GPP TS 08.16, 7.5.1) Sponsored-by: On-Waves ehf
2013-10-26lapd: Extend the test to check if lapdm_channel_exit is idempotentHolger Hans Peter Freyther1-0/+10
I have a crash with an older libosmocore and the sysmobts. I am not sure how we can have a release for a channel where the lapdm_channel has not gone through lapdm_channel_init. But to prevent the crash we can promise lapdm_channel_exit to be idempotent. It has been idempotent since f5a079f739c57d8be7c59149fd45475c402a45fc
2013-10-25gprs: Address coverity warning for gprs_ns_tx_status resultHolger Hans Peter Freyther1-8/+10
Add a #define for the check and use this in this path as well. Fixes: Coverity CID 1103092
2013-10-25gprs: Address coverity warning on unchecked return of gprs_ns_tx_reset_ackHolger Hans Peter Freyther1-1/+5
Fixes: Coverity CID 1111545
2013-10-25gprs: Address coverity warning on unchecked return of gprs_ns_tx_statusHolger Hans Peter Freyther1-1/+4
We could consider creating a CHECK MACRO that will print a message in case of a tx failure. Fixes: Coverity CID 1111544
2013-10-25gprs: Make sure that the buf is NULL terminated at the endHolger Hans Peter Freyther1-0/+1
Fixes: Coverity CID 1107253
2013-10-25debian: Update the changelogHolger Hans Peter Freyther1-1/+2
2013-10-24gb: Create new NSVC object instead of patching the NSVCIJacob Erlbeck3-16/+40
When a RESET is received on the same link with a different NSVCI from a BSS on a dynamically created NS connection do not patch the nsvc object but create a new one instead. Thus the NSVCI is never modified at a nsvc object after the NS-VC has been established. Sponsored-by: On-Waves ehf
2013-10-24gb: Fix RESET handling with changing NSEIJacob Erlbeck2-50/+67
This modifies the NS stack's behavior to accept RESET and RESET_ACK NSEI changes for NS-VC dynamically created by RESET messages from BSSes. This feature is not used for NS-VC configured via VTY or NS-VC to a SGSN. Sponsored-by: On-Waves ehf
2013-10-24gb: Fix NS RESET/RESET_ACK abnormal casesJacob Erlbeck4-157/+294
This changes the implementations for the reception of RESET and RESET_ACK to be compatible with 3GPP TS 08.16, 7.3.1: - Just send a RESET_ACK with correct values back to the SGSN when a RESET with an invalid NSVCI or NSEI has been received. - Check RESET_ACK for matching NSEI and NSVCI. - Ignore unexpected RESET_ACKs. In addition, use RESET_ACK from a BSS to update the BSS source address based on the NSVCI to be tolerant with changing UDP source addresses/ports. Sponsored-by: On-Waves ehf
2013-10-24gb: Add test cases for NS RESET proceduresJacob Erlbeck2-0/+703
Add a test handling proper and mismatching RESETs. The latter may occur, when ports change within a NS-VC without the SGSN getting notice. This tests for the behavior of the NS protocol stack for RESET and RESET_ACK messages which changing/invalid NSEI and NSVCI like it is being described in 3GPP TS 08.16, 7.3.1. Sponsored-by: On-Waves ehf
2013-10-24gb: Fix gprs_nsvc_delete() to free ctr groupJacob Erlbeck3-0/+128
This fixes a SEGV error that happens the next time the statistics are updated. Addresses: Program terminated with signal 11, Segmentation fault. #0 0xb7711fa5 in rate_ctr_group_intv (grp=<optimized out>) at rate_ctr.c:107 107 for (i = 0; i < grp->desc->num_ctr; i++) { #0 0xb7711fa5 in rate_ctr_group_intv (grp=<optimized out>) at rate_ctr.c:107 #1 rate_ctr_timer_cb (data=0x0) at rate_ctr.c:129 #2 0xb770ec59 in osmo_timers_update () at timer.c:243 #3 0xb770ef7a in osmo_select_main (polling=0) at select.c:133 #4 0x08049987 in main (argc=3, argv=0xbfba8084) at gb_proxy_main.c:306 Sponsored-by: On-Waves ehf
2013-10-24gb/vty: Fix the VTY node string for L_NS_NODEJacob Erlbeck1-1/+1
Use 'config-ns' instead of plain 'ns' and append a blank after the '#' to make the vty python test script work. Sponsored-by: On-Waves ehf
2013-10-24gb/vty: Perform NS-VC operations based on NS-VCIJacob Erlbeck1-5/+15
This adds a 'nsvc nsvci <0-65535> (block|unblock|reset)' vty command. It selects the NS-VC based on the nsvci instead of using the first with a matching NSEI, like it is done when the 'nsei' keyword is used instead. Sponsored-by: On-Waves ehf
2013-10-17misc: Ignore generated filesHolger Hans Peter Freyther1-0/+2
* compile is generated by newer automake * ignore the test binary
2013-10-17debian: Bump the changelog for some new packagesHolger Hans Peter Freyther1-1/+2
2013-10-17gb: Fix gprs_active_nsvc_by_nsei()Jacob Erlbeck2-12/+12
The state matching condition is inverted. This is corrected by this fix. Sponsored-by: On-Waves ehf
2013-10-17gb: Test sending messages to the SGSNJacob Erlbeck2-53/+418
This adds tests for the gprs_ns_sendmsg() function. For this it merges back functions from the gbproxy test. Sponsored-by: On-Waves ehf