aboutsummaryrefslogtreecommitdiffstats
path: root/src/gsm/gsm0808.c
diff options
context:
space:
mode:
authorNeels Hofmeyr <neels@hofmeyr.de>2019-04-10 19:23:45 +0200
committerNeels Hofmeyr <neels@hofmeyr.de>2019-04-26 20:36:39 +0200
commit302aafc3e22d552638120a17b1730b585767443e (patch)
treea0f584d087d2129c331ef86277a82cc3486d15b5 /src/gsm/gsm0808.c
parentaffbb2064669a58aea4a18f773eed90b15dffcf9 (diff)
BSSMAP: tweaks
Change two instances of Speech Version values to enum gsm0808_permitted_speech. It is often not trivial to find the right values for a uint8_t member, giving the enum name makes it a lot easier/safer to use. In gsm0808_create_handover_required(), use msgb_tv_put() so that the enum's storage size doesn't matter. (Already used for handover_performed) Fix typo in doc of gsm0808_create_handover_required(). Change-Id: I6387836bab76e1fa42daa0f42ab94fc14b70b112
Diffstat (limited to 'src/gsm/gsm0808.c')
-rw-r--r--src/gsm/gsm0808.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/gsm/gsm0808.c b/src/gsm/gsm0808.c
index 48730766..3307a5dd 100644
--- a/src/gsm/gsm0808.c
+++ b/src/gsm/gsm0808.c
@@ -822,7 +822,7 @@ static uint8_t put_old_bss_to_new_bss_information(struct msgb *msg,
/*! Create BSSMAP HANDOVER REQUIRED message.
* \param[in] params All information to be encoded.
- * \returns newly allocated msgb with BSSMAP REQUIRED message. */
+ * \returns newly allocated msgb with BSSMAP HANDOVER REQUIRED message. */
struct msgb *gsm0808_create_handover_required(const struct gsm0808_handover_required *params)
{
struct msgb *msg;
@@ -846,7 +846,7 @@ struct msgb *gsm0808_create_handover_required(const struct gsm0808_handover_requ
/* Speech Version (Used), 3.2.2.51 */
if (params->speech_version_used_present)
- msgb_tv_fixed_put(msg, GSM0808_IE_SPEECH_VERSION, 1, &params->speech_version_used);
+ msgb_tv_put(msg, GSM0808_IE_SPEECH_VERSION, params->speech_version_used);
if (params->old_bss_to_new_bss_info_present)
put_old_bss_to_new_bss_information(msg, &params->old_bss_to_new_bss_info);