aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHarald Welte <laforge@osmocom.org>2021-01-21 12:46:04 +0100
committerHarald Welte <laforge@osmocom.org>2021-01-21 12:48:46 +0100
commitb3d4778efbf437d637c66ae70adc1cfb37da0bdb (patch)
treead2d6fa34c623b523c936d552e631efed51d88c0
parent43cb90ff5dbb7f420f2fdbc0e97b697ab25ba2f8 (diff)
Revert "gprs_ns2_vc_fsm: check NSEI match the NSE"
This reverts commit 842599ca6252b9d65504fbe55148c6aad86f7025. Closes: OS#4965 Change-Id: I96882961e179bb63e3f4095571135244148dde20
-rw-r--r--src/gb/gprs_ns2_vc_fsm.c14
1 files changed, 0 insertions, 14 deletions
diff --git a/src/gb/gprs_ns2_vc_fsm.c b/src/gb/gprs_ns2_vc_fsm.c
index 3ec69097..fc2a86a8 100644
--- a/src/gb/gprs_ns2_vc_fsm.c
+++ b/src/gb/gprs_ns2_vc_fsm.c
@@ -750,7 +750,6 @@ int gprs_ns2_vc_rx(struct gprs_ns2_vc *nsvc, struct msgb *msg, struct tlv_parsed
struct osmo_fsm_inst *fi = nsvc->fi;
int rc = 0;
uint8_t cause;
- uint16_t nsei;
/* TODO: 7.2: on UNBLOCK/BLOCK: check if NS-VCI is correct,
* if not answer STATUS with "NS-VC unknown" */
@@ -764,19 +763,6 @@ int gprs_ns2_vc_rx(struct gprs_ns2_vc *nsvc, struct msgb *msg, struct tlv_parsed
}
}
- if (TLVP_PRESENT(tp, NS_IE_NSEI)) {
- nsei = tlvp_val16be(tp, NS_IE_NSEI);
- if (nsei != nsvc->nse->nsei) {
- /* 48.016 ยง 7.3.1 send, RESET_ACK to wrong NSVCI + ignore */
- if (nsh->pdu_type == NS_PDUT_RESET)
- ns2_tx_reset_ack(nsvc);
-
- LOGNSVC(nsvc, LOGL_ERROR, "Rx %s with wrong NSEI=%05u. Ignoring PDU.\n",
- get_value_string(gprs_ns_pdu_strings, nsh->pdu_type), nsei);
- goto out;
- }
- }
-
switch (nsh->pdu_type) {
case NS_PDUT_RESET:
osmo_fsm_inst_dispatch(fi, GPRS_NS2_EV_RX_RESET, tp);