aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPau Espin Pedrol <pespin@espeweb.net>2020-12-18 17:19:29 +0100
committerpespin <pespin@sysmocom.de>2020-12-23 12:39:17 +0000
commit3f6a282a14a2e809eb6ab154d46dbff0dc0898b5 (patch)
treed60634fbfabf8db9aaef3bd4d34224c7e24090be
parentb6b62cded0abc5d62322ef076d7fa39149f3a525 (diff)
Revert "rest_octets: fix encoding of 3G Early Classmark Sending Restriction"
This reverts commit c9eab828ea4a9f508a013cf5cc1e0384a0e62e4c. The initial code was correct, which has also been used in osmo-bsc until recently, where it moved to use this function from libosmocore and errors started to show up in TTCN3 tests. See 3GPP TS 44.018 Section 10.5.2.34 / Table 10.5.2.34.1: "SI 3 Rest Octets information element": """ <SI3 Rest Octet> ::= ... <3G Early Classmark Sending Restriction> ... <3G Early Classmark Sending Restriction>::= L | H; """ Change-Id: I0ee48d3240c62c4d2e15063b26da7a2a617f383e Related: OS#3075 Related: SYS#4021
-rw-r--r--src/gsm/gsm48_rest_octets.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/gsm/gsm48_rest_octets.c b/src/gsm/gsm48_rest_octets.c
index 3a424f7e..90f2b03c 100644
--- a/src/gsm/gsm48_rest_octets.c
+++ b/src/gsm/gsm48_rest_octets.c
@@ -611,9 +611,9 @@ int osmo_gsm48_rest_octets_si3_encode(uint8_t *data, const struct osmo_gsm48_si_
/* 3G Early Classmark Sending Restriction. If H, then controlled by
* early_cm_ctrl above */
if (si3->early_cm_restrict_3g)
- bitvec_set_bit(&bv, H);
- else
bitvec_set_bit(&bv, L);
+ else
+ bitvec_set_bit(&bv, H);
if (si3->si2quater_indicator) {
bitvec_set_bit(&bv, H); /* indicator struct present */