aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAlexander Couzens <lynxis@fe80.eu>2019-04-27 23:19:55 +0200
committerHarald Welte <laforge@gnumonks.org>2019-05-07 13:20:57 +0000
commitcc72cc45a49b13b0c5147a7af21c083e47ca73f5 (patch)
tree7223813047542b5e2a27011e99a12fe50be25efb
parentaa98c481fa7888e2bcd9d5c9ae1993744ee47f33 (diff)
add osmo_stat_item_inc/osmo_stat_item_dec to set it relative
-rw-r--r--include/osmocom/core/stat_item.h2
-rw-r--r--src/stat_item.c24
-rw-r--r--tests/stats/stats_test.c16
3 files changed, 42 insertions, 0 deletions
diff --git a/include/osmocom/core/stat_item.h b/include/osmocom/core/stat_item.h
index 260ffb1..806173a 100644
--- a/include/osmocom/core/stat_item.h
+++ b/include/osmocom/core/stat_item.h
@@ -79,6 +79,8 @@ static inline void osmo_stat_item_group_udp_idx(
void osmo_stat_item_group_free(struct osmo_stat_item_group *statg);
+void osmo_stat_item_inc(struct osmo_stat_item *item, int32_t value);
+void osmo_stat_item_dec(struct osmo_stat_item *item, int32_t value);
void osmo_stat_item_set(struct osmo_stat_item *item, int32_t value);
int osmo_stat_item_init(void *tall_ctx);
diff --git a/src/stat_item.c b/src/stat_item.c
index cb9b90f..6716575 100644
--- a/src/stat_item.c
+++ b/src/stat_item.c
@@ -150,6 +150,30 @@ void osmo_stat_item_group_free(struct osmo_stat_item_group *grp)
talloc_free(grp);
}
+/*! Increase the stat_item to the given value.
+ * This function adds a new value for the given stat_item at the end of
+ * the FIFO.
+ * \param[in] item The stat_item whose \a value we want to set
+ * \param[in] value The numeric value we want to store at end of FIFO
+ */
+void osmo_stat_item_inc(struct osmo_stat_item *item, int32_t value)
+{
+ int32_t oldvalue = item->values[item->last_offs].value;
+ osmo_stat_item_set(item, oldvalue + value);
+}
+
+/*! Descrease the stat_item to the given value.
+ * This function adds a new value for the given stat_item at the end of
+ * the FIFO.
+ * \param[in] item The stat_item whose \a value we want to set
+ * \param[in] value The numeric value we want to store at end of FIFO
+ */
+void osmo_stat_item_dec(struct osmo_stat_item *item, int32_t value)
+{
+ int32_t oldvalue = item->values[item->last_offs].value;
+ osmo_stat_item_set(item, oldvalue - value);
+}
+
/*! Set the a given stat_item to the given value.
* This function adds a new value for the given stat_item at the end of
* the FIFO.
diff --git a/tests/stats/stats_test.c b/tests/stats/stats_test.c
index 6ef8841..71f710a 100644
--- a/tests/stats/stats_test.c
+++ b/tests/stats/stats_test.c
@@ -147,6 +147,22 @@ static void stat_test(void)
OSMO_ASSERT(value == 1000 + i);
}
+ /* check if dec & inc is working */
+ osmo_stat_item_set(statg->items[TEST_A_ITEM], 42);
+ rc = osmo_stat_item_get_next(statg->items[TEST_A_ITEM], &rd_a, &value);
+ OSMO_ASSERT(rc > 0);
+ OSMO_ASSERT(value == 42);
+
+ osmo_stat_item_dec(statg->items[TEST_A_ITEM], 21);
+ rc = osmo_stat_item_get_next(statg->items[TEST_A_ITEM], &rd_a, &value);
+ OSMO_ASSERT(rc > 0);
+ OSMO_ASSERT(value == 21);
+
+ osmo_stat_item_inc(statg->items[TEST_A_ITEM], 21);
+ rc = osmo_stat_item_get_next(statg->items[TEST_A_ITEM], &rd_a, &value);
+ OSMO_ASSERT(rc > 0);
+ OSMO_ASSERT(value == 42);
+
/* Keep 2 in FIFO */
osmo_stat_item_set(statg->items[TEST_A_ITEM], 33);
osmo_stat_item_set(statg->items[TEST_B_ITEM], 1000 + 33);