From 8254cf4f2a66fab40a31c1bdccfff13947ff6592 Mon Sep 17 00:00:00 2001 From: Neels Hofmeyr Date: Mon, 25 Dec 2017 00:45:24 +0100 Subject: error log: sccp_scoc.c: log failure to create/resolve conn_id Tweak the FIXMEs to clarify that we're lacking a reply to the SCCP user besides log output. Change-Id: Ib235ff8e264aaf0c2e9794f464a3ba7b54816f3d --- src/sccp_scoc.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/sccp_scoc.c b/src/sccp_scoc.c index e0742f9..3de986d 100644 --- a/src/sccp_scoc.c +++ b/src/sccp_scoc.c @@ -1623,7 +1623,9 @@ int osmo_sccp_user_sap_down(struct osmo_sccp_user *scu, struct osmo_prim_hdr *op /* Allocate new connection structure */ conn = conn_create_id(inst, prim->u.connect.conn_id); if (!conn) { - /* FIXME: inform user */ + /* FIXME: inform SCCP user with proper reply */ + LOGP(DLSCCP, LOGL_ERROR, "Cannot create conn-id for primitive %s\n", + osmo_scu_prim_name(&prim->oph)); goto out; } conn->user = scu; @@ -1635,7 +1637,9 @@ int osmo_sccp_user_sap_down(struct osmo_sccp_user *scu, struct osmo_prim_hdr *op /* Resolve existing connection structure */ conn = conn_find_by_id(inst, scu_prim_conn_id(prim)); if (!conn) { - /* FIXME: inform user */ + /* FIXME: inform SCCP user with proper reply */ + LOGP(DLSCCP, LOGL_ERROR, "Received unknown conn-id %u for primitive %s\n", + scu_prim_conn_id(prim), osmo_scu_prim_name(&prim->oph)); goto out; } break; -- cgit v1.2.3