From 03e3b0423443cd48f901762e36e8aa5b75c27c37 Mon Sep 17 00:00:00 2001 From: Harald Welte Date: Fri, 30 Apr 2021 12:06:20 +0200 Subject: osmo_ss7: free the sock_name string once an ASP socket is closed It's confusing to keep around a string representation of what peer the socket was previously connected to. Change-Id: I00d47fc355bfe24915653767ad75c1f491c060d5 --- src/osmo_ss7.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/osmo_ss7.c b/src/osmo_ss7.c index 6d68290..617f6bb 100644 --- a/src/osmo_ss7.c +++ b/src/osmo_ss7.c @@ -1759,6 +1759,10 @@ static void xua_cli_close(struct osmo_stream_cli *cli) osmo_fsm_inst_dispatch(asp->fi, XUA_ASP_E_SCTP_COMM_DOWN_IND, asp); /* send M-SCTP_RELEASE.ind to XUA Layer Manager */ xua_asp_send_xlm_prim_simple(asp, OSMO_XLM_PRIM_M_SCTP_RELEASE, PRIM_OP_INDICATION); + + /* no connection means no socket means no socket name */ + talloc_free(asp->sock_name); + asp->sock_name = NULL; } static void xua_cli_close_and_reconnect(struct osmo_stream_cli *cli) @@ -1892,6 +1896,10 @@ static int xua_srv_conn_closed_cb(struct osmo_stream_srv *srv) osmo_ss7_asp_destroy(asp); } + /* no connection means no socket means no socket name */ + talloc_free(asp->sock_name); + asp->sock_name = NULL; + return 0; } -- cgit v1.2.3