AgeCommit message (Collapse)AuthorFilesLines
2018-12-27systemd service: add save_log_tail35c3Neels Hofmeyr1-0/+1
Change-Id: Iceca2934a5451f27e94322ab76ef9336771fced0
2018-12-20fix ipa_asp_fsm down state transitionStefan Sperling1-22/+27
Properly transition into IPA_ASP_S_DOWN from IPA_ASP_S_ACTIVE and fix the mask of legal out states from IPA_ASP_S_ACTIVE. BSC-sccplite tests are still passing with this change. Change-Id: Idb8e7bd1c74a4b47080fe32ebe0161c503ead571 Related: OS#3111
2018-12-06contrib: fix makedistcheck with disabled systemdOliver Smith1-1/+2
EXTRA_DIST files need to be distributed, no matter if the systemd option is configured or not. Change-Id: Ib848aa5ce03f45d4f8182a4e77b0130ccb261635
2018-12-05contrib/jenkins.sh: build and publish manualsOliver Smith1-2/+19
Add new environment variables WITH_MANUALS and PUBLISH to control if the manuals should be built and uploaded. Describe all environment vars on top of the file. When WITH_MANUALS is set, install osmo-gsm-manuals like any other dependency and add --enable-manuals to the configure flags (for "make" and "make distcheck"). Add the bin subdir of the installed files to PATH, so osmo-gsm-manuals-check-depends can be used by ./configure. Related: OS#3385 Change-Id: I5904c86c7e38d36d23df213f5a2ae1986647a051
2018-12-04Fix DISTCHECK_CONFIGURE_FLAGS overrideOliver Smith1-1/+1
Set AM_DISTCHECK_CONFIGURE_FLAGS in Makefile.am instead of DISTCHECK_CONFIGURE_FLAGS. This is the recommended way from the automake manual, as otherwise the flag can't be changed by the user anymore. Related: OS#3718 Change-Id: Ib3f443e07f51df352357c5a90792bd946efcdf27
2018-11-27build manuals moved here from osmo-gsm-manuals.gitOliver Smith7-26/+87
Moved to doc/manuals/, with full commit history, in preceding merge commit. Now incorporate in the build system. Build with: $ autoreconf -fi $ ./configure --enable-manuals $ make Shared files from osmo-gsm-manuals.git are found automatically if - the repository is checked out in ../osmo-gsm-manuals; or - if it osmo-gsm-manuals was installed with "make install"; or - OSMO_GSM_MANUALS_DIR is set. Related: OS#3385 Change-Id: Ib5a22c2ea81fdde036bf9efb47d785a830b88c93
2018-11-27Merge history from osmo-gsm-manuals.gitNeels Hofmeyr6-0/+1662
Change-Id: Iabd0af069f00e7827a7793aabfc38a14fb7f1570
2018-11-27stp: update vty reference with added SCCP commandsNeels Hofmeyr1-1/+99
After I66e97706de0c546db3c6ff77fb5e6ac6e32bff55 which adds the missing sccp_vty_init(), update VTY reference with the new SCCP show / config commands. Depends: I66e97706de0c546db3c6ff77fb5e6ac6e32bff55 Change-Id: Id941b8e31d3b4cfdb3f912beedc1e7af321a0113
2018-11-27stp: update vty referenceNeels Hofmeyr1-55/+130
Change-Id: Id5f1067760db7a11ec380a541bfe7357a21a3bb3
2018-11-27vty-ref: Update URI of docbook 5.0 schemaHarald Welte1-2/+2
... to match the /etc/xml/catalog file on debian (no "www" in hostname) Change-Id: Id9f3579c7f2bc3af13fe30b5268f249b6f59ed0d
2018-11-27OsmoSTP: update VTY referenceNeels Hofmeyr1-1742/+1359
This is the first update since the libosmocore changes to the 'show online-help' generated output. Hence the produced document now benefits from the structural improvements: - not repeating common commands for every node; - using section names that match the VTY prompt. Change-Id: I98cdfcb6c1c7db49ab106e775be92e4c6adeab17
2018-11-27STP: Update vty reference XML fileHarald Welte2-2/+1742
This ensures useful content in the STP vty reference manual Change-Id: Ica4b1c0172255ec2328562fdd8fac190e3ad448d
2018-11-27First step towards an OsmoSTP manualHarald Welte6-0/+132
Change-Id: I450bfac7444ac9cb7f50c086d87cf7157c2e2a31
2018-11-27Importing history from osmo-gsm-manuals.gitNeels Hofmeyr0-0/+0
Change-Id: I17bfe64d98ca47cb4b3be81d2715bda047b79466
2018-11-22SS7: safeguard against wrong number of pointcode componentMax1-1/+2
Previously internal function get_pc_comp_shift() returned negative error code when called with wrong component number despite unsigned return value which wasn't checked for error anyway. Fix this by using explicit assert in the error path. This should not affect external users because this function always called with constant component argument. Change-Id: Ib24cdbcf614bad68f3cfa9776a451c5c1e45ae6e
2018-11-19Log ip:port for created SS7 serverMax1-1/+4
Change-Id: If2ae093175d64000490a2be31ecfea265ca3853d
2018-11-19Make pointcode width function publicMax2-3/+5
That's useful for external programs veryfying pointcode validity. For example if used as part of BSS-related identity in GCR construction by LCLS code we should be able to double.check that no significant bits off pointcode are lost/ignored. Change-Id: I5a9981dd2c1d78966c61a3f6b50c7c0d9b542caf
2018-11-18osmo-stp: add SCCP related VTY commandsNeels Hofmeyr1-0/+1
Call osmo_sccp_vty_init(), so far forgotten. This adds the various 'show cs7 instance N sccp *' commands, as well as making the SCCP timers configurable. See Id941b8e31d3b4cfdb3f912beedc1e7af321a0113 for a diff of the VTY reference, showing what commands are enabled by this patch. Change-Id: I66e97706de0c546db3c6ff77fb5e6ac6e32bff55
2018-11-09return error code from xua_srv_conn_cb() if conn is freedStefan Sperling1-1/+5
Allow callers of xua_srv_conn_cb() to tell whether conn was freed by returning error code EBADF, which is also used elsewhere in osmocom programs for this purpose. This is necessary because xua_srv_conn_cb() might be running inside of a loop which checks for read and then write events on the connection. If the connection is freed by xua_srv_conn_cb() as part of processing a read event, callers should avoid further processing of events. But if we don't return an error we are leaving callers none the wiser and with a dangling conn pointer. Change-Id: I7359667b2f25d6c45acc70049b2a4ee2f376a1df Related: OS#3685
2018-10-29skip simple-client default as/asp when saving VTY configStefan Sperling3-4/+11
When saving the current VTY config to a configuration file, do not write out AS/ASP configuration items which are generated as a fallback by osmo_sccp_simple_client_on_ss7_id(). Since the user did not explicitly configure these configuration items they should not be saved to the user's configuration file. Change-Id: Id8a3afc6dee29ae1ee9c862cbe404a61fe979dba Related: OS#3616
2018-10-21build: move include/{mtp,sccp} to include/osmocom/Neels Hofmeyr17-12/+12
Anywhere else in the Osmocom code base, we arrange headers in include/osmocom/foo/ and pass -I ${root_srcdir}/include/. This way including an osmocom header always has the format #include <osmocom/foo/bar.h> whether we are including from the local source tree or from $prefix. For some reason not clear to me, the mtp and sccp folders, even though they are being installed to $prefix/include/osmocom/, were kept *next* to the osmocom/ dir, instead of inside it. Fix that weird situation. The motivation is that I wanted to use a definition from sccp_types.h in a public-API header. That is impossible if it requires #include <sccp/sccp_types.h> in a local build, but #include <osmocom/sccp/sccp_types.h> for any other source tree using libosmo-sccp. After this patch, both are identical and including works without quirks. (The other patch that needed this has changed in the meantime on and no longer needs this, but this still makes sense for future hacking.) The installed result does not change, since both mtp/*.h and sccp/*.h have always been installed to $prefix/include/osmocom/{mtp,sccp}/. This merely changes their position in the source tree. The most curious situation before this is that any patch #including <osmocom/sccp/sccp_types.h> might not get a notice that the header didn't exist, but might instead include an older system-installed file. Change-Id: I1209a4ecf9f692a8030b5c93cd281fc9dd58d105
2018-09-27make SCCP timers configurableNeels Hofmeyr6-27/+327
The previous hardcoded SCCP timers may cause SCCP connection releases, if the peer is configured with far lower timers than libosmo-sccp. Testing with a specific SCCPlite MSC, I experienced an iar of just over three minutes, meaning that calls would be cut off by the MSC, since the osmo-bsc failed to send an Inactivity Timer message until seven minutes have passed. With this patch, SCCP timers are configurable by the user. Define constant global default timers, and variable user-configurable timers with each osmo_sccp_instance. Add VTY UI to configure the timers. Users must call osmo_sccp_vty_init() to get the sccp-timer config nodes under the 'cs7' node. Show the new UI in ss7_asp_test.vty. Note that even though this function is not new at all, until recently, all of our SCCP users (osmo-bsc, osmo-msc, osmo-sgsn, osmo-hnbgw) failed to call osmo_sccp_vty_init(), and thus also missed out on the various 'show' commands defined in sccp_vty.c. In other words, to benefit from the timer configurability, the patches to call osmo_sccp_vty_init() must first be merged to the corresponding master branches. If a 'sccp-timer' config command occurs, the cs7 instance must allocate an SCCP instance in order to store the timer config. Do that by calling the recently added osmo_ss7_ensure_sccp() function. Hence remove the limitation that the SCCP instance must not be populated from the "simple" setup function. If we want to configure SCCP timers beforehand, there must be an SCCP instance for that, and there is no hard reason to require a NULL SCCP instance, besides the desire to prevent this function from being invoked twice. Change-Id: I28a7362aa838e648ecc9b26ee53dbcade81a9d65
2018-09-27sccp_vty: fix doc strings for show ... ssn,connectionsNeels Hofmeyr2-5/+6
For 'show cs7 instance 0 ssn', fix doc string for 'ssn', and add missing one for the SSN arg. This fixes depending builds that see VTY test failures due to the missing doc string. For 'show cs7 instance 0 connectsion', fix doc string for 'connections'. Change-Id: I214ea51fc6bfa2a9a4dd7c34b43add0c77ffe22e
2018-09-27cosmetic: allocate ss7->sccp in one common functionNeels Hofmeyr3-8/+20
Instead of allocating ss7->sccp in various places, unify that in one common function. We shouldn't spread the decision what to pass as priv pointer around everywhere. There is no functional difference. This is preparation for a patch where the sccp_instance gets allocated from the telnet VTY: I would prefer to hide all allocation details from that code; which also makes sense for the other callers of osmo_sccp_instance_create(). Change-Id: Ie912898c66d31ce4ac8eeeea5a6ddc3f821c06f7
2018-09-27vty: install 'show cs7' for sccp addrs on _ve nodesNeels Hofmeyr2-5/+13
The 'show cs7 instance 0 sccp-addressbook' command should not be inside the 'cs7' node. That defies the point of naming the instance again, and it falls out of place of all the other 'show cs7' commands on the VIEW and ENABLE nodes. Drop the old command within the 'cs7' node without substitution or deprecation. At the same time, drop dash from 'show cs7 i 0 sccp-addressbook' There are various other show cs7 commands already defined in sccp_vty.c, which have 'sccp' as a separate string. Conform to that. Change-Id: I80e0bc0a91bcd3fb75372045db34592d2d663d41
2018-09-27vty: tweak two printed stringsNeels Hofmeyr2-4/+4
Fix typo "to long". Say 'cs7 instance' instead of 'ss7 instance': we are interacting with a user on the telnet VTY, and that user is configuring a 'cs7 instance'. Especially a lowercase 'ss7' is potentially confusing ("is there an 'ss7' node?"). Changes show in ss7_asp_test.vty. Change-Id: Iebb976531576268d58338895a4baadbca6137b80
2018-09-27sccp_vty: define SCCP_STR onceNeels Hofmeyr3-7/+6
Define SCCP_STR in sccp_internal.h, because I know that I want to also use it in osmo_ss7_vty.c. Fix "Signaling" to "Signalling" upon copying the old string. Change-Id: Ic93e4771147070a9222c73f80b5f7c29ae7eec35
2018-09-27add tests/vty: VTY UI transcript testingNeels Hofmeyr6-3/+621
Add ss7_asp_vty_test, a shim test program with the sole purpose of exposing the cs7 VTY nodes. Add ss7_asp_test.vty, transcript for verifying VTY nodes using above program. Add --enable-external-tests to configure. Run jenkins.sh with --enable-external-tests. Change-Id: I6a28684fa24d6e7de568623444297028eba2ab8c
2018-09-27allow less characters for SCCP address book entriesNeels Hofmeyr1-1/+1
Allowing a whole line of characters as address book name would be a lot, allowing 512 characters is completely ridiculous. That's more than this entire commit log message! 32 is plenty. All linking programs should automatically get the limitation in their VTY parsing without any changes. Configs with sccp-addr names > 31 chars will no longer work after this. Change-Id: I3ecf83d620e46f7bf9857fc60a93d4e240ee3b8a
2018-09-27vty: fix 'show asp' from within 'asp' nodeNeels Hofmeyr1-1/+2
When entering an 'cs7' / 'asp' node, and invoking 'do show cs7 i 0 asp', the ASP's FSM instance is not yet allocated. Hence attempting to print its status will result in a segfault. Spotted this while writing VTY tests that will follow shortly in another patch (I6a28684fa24d6e7de568623444297028eba2ab8c). Change-Id: I3ebf498492c6ba69a5dd1c9f36acdabfd6fbdfe1
2018-09-26drop inaccurate comment from osmo_ss7_vty.cNeels Hofmeyr1-1/+0
Change-Id: I845f6661eaed361b5d4db88140efb8eb79b6b69d
2018-09-26cosmetic: sccp_scoc.c: fix timers definition unitsNeels Hofmeyr1-9/+9
The SCCP timer units are not what the comments say: Milliseconds are 1000 * seconds, not 100. Also, microseconds are 1000000 * seconds. Interestingly enough, MSEC_TO_US() tried to fix the wrong hundredth-seconds to microseconds by multiplying by 10, however, it should end up at a factor of a million, not a thousand, hence would result in wrong sub-second fractions. But, since none of the current timers use sub-second fractions, none of the timers are actually affected in practice. Hence this patch is merely cosmetic. Since all use of the timer constants is wrapped in MSEC_TO_US(), we can transparently fix all those values and their use: - define the constants in milliseconds (replace "100" with "1000"). - in MSEC_TO_US(), divide-and-mod by 1000. - in MSEC_TO_US(), actually calculate microseconds. BTW, I am about to make the timers VTY configurable, but before I get confused, I'd rather fix these units first. Change-Id: Ia6c893f734fbdc88873c4ef80f6cacf01ee7763a
2018-09-25osmo-stp.cfg: Ensure example config is well-formedHarald Welte1-8/+8
Change-Id: I042486249ae1390a4fedbcf356e488451277788f
2018-09-14debian: Document why enable-static is used in dh_auto_configurePau Espin Pedrol1-0/+2
Change-Id: I4a7215d350e023dceadc5826be68ce366a185da1
2018-09-12Install sample cfg file to /etc/osmocomPau Espin Pedrol2-1/+5
Change-Id: I437e6ada9f391eece75b2f2e2af3bec4e8e9f6ce
2018-09-10debian/rules: Remove duplicated override_dh_auto_test sectionPau Espin Pedrol1-4/+0
Change-Id: Iaf3a7448d10832cc27afa04fe482da31d7582660
2018-09-10Install systemd services with autotoolsPau Espin Pedrol7-3/+29
This commit re-adds ba3da6d72564bb2c60f4f4a8d641b8a7b86d1f59, plus fixes two typos (sytemd->systemd) in that commit. The commit is fine, we just need to add some extra configure flags in osmo-ci.git. Depends: https://gerrit.osmocom.org/#/c/osmo-ci/+/10857/ Change-Id: Ifc11d97c0c5fe1f7872b59147b1548b56951921b
2018-09-09Revert "Install systemd services with autotools"Harald Welte7-29/+3
This reverts commit ba3da6d72564bb2c60f4f4a8d641b8a7b86d1f59. That commit broke master-{osmo-iuh,osmo-msc,osmo-sgsn,openbsc,osmo-bsc} build jobs with make[4]: Nothing to be done for 'install-exec-am'. /bin/mkdir -p '/lib/systemd/system' /usr/bin/install -c -m 644 osmo-stp.service '/lib/systemd/system' /usr/bin/install: cannot create regular file '/lib/systemd/system/osmo-stp.service': Permission denied make[4]: *** [install-systemdsystemunitDATA] Error 1 Change-Id: I009825d293e7e7a6c48d10452c10b3bb6da3e684
2018-09-07Install systemd services with autotoolsPau Espin Pedrol7-3/+29
Change-Id: Ie77ee4b32a75e2d207030ddc78d39fb664103d33
2018-08-20ipa_asp_fsm: init: expect IPA ID ACK, not GETNeels Hofmeyr1-2/+2
Testing with an actual SCCPlite MSC, I see the IPA connection starting out by the MSC sending an IPA ID ACK. Make the ipa_asp_fsm match that. Change-Id: Icffda98579e676ab6ca63c9c22cf5d151c4fe95f
2018-08-13xua_rkm: Fix xua_msg memleank in handle_rkey_reg_respPau Espin Pedrol1-0/+2
From LeakSanitizer report: Indirect leak of 384 byte(s) in 3 object(s) allocated from: #0 0x7f986da27d99 in __interceptor_malloc /build/gcc/src/gcc/libsanitizer/asan/asan_malloc_linux.cc:86 #1 0x7f9868d0cb61 in _talloc_zero (/usr/lib/libtalloc.so.2+0x5b61) #2 0x7f986ad33766 in xua_msg_add_data /home/pespin/dev/sysmocom/git/libosmo-sccp/src/xua_msg.c:73 #3 0x7f986ad343c3 in xua_from_msg_common /home/pespin/dev/sysmocom/git/libosmo-sccp/src/xua_msg.c:143 #4 0x7f986ad347d2 in xua_from_nested /home/pespin/dev/sysmocom/git/libosmo-sccp/src/xua_msg.c:201 #5 0x7f986ad65563 in m3ua_rx_rkm_reg_rsp /home/pespin/dev/sysmocom/git/libosmo-sccp/src/xua_rkm.c:431 #6 0x7f986ad65f96 in m3ua_rx_rkm /home/pespin/dev/sysmocom/git/libosmo-sccp/src/xua_rkm.c:510 #7 0x7f986ad31ef7 in m3ua_rx_msg /home/pespin/dev/sysmocom/git/libosmo-sccp/src/m3ua.c:749 #8 0x7f986ad7c1e8 in xua_cli_read_cb /home/pespin/dev/sysmocom/git/libosmo-sccp/src/osmo_ss7.c:1590 #9 0x7f986a66cdb4 in osmo_stream_cli_read /home/pespin/dev/sysmocom/git/libosmo-netif/src/stream.c:192 #10 0x7f986a66e091 in osmo_stream_cli_fd_cb /home/pespin/dev/sysmocom/git/libosmo-netif/src/stream.c:276 #11 0x7f986994e795 in osmo_fd_disp_fds /home/pespin/dev/sysmocom/git/libosmocore/src/select.c:217 #12 0x7f986994eabb in osmo_select_main /home/pespin/dev/sysmocom/git/libosmocore/src/select.c:257 #13 0x5630cb294bd3 in main /home/pespin/dev/sysmocom/git/osmo-msc/src/osmo-msc/msc_main.c:697 #14 0x7f98678b806a in __libc_start_main (/usr/lib/libc.so.6+0x2306a) #15 0x5630cb292649 in _start (/home/pespin/dev/sysmocom/build/new/out/bin/osmo-msc+0x185649) Following code paths: m3ua_rx_rkm_reg_rsp xua_from_nested xua_from_msg_common xua_msg_add_data talloc_zero (part) handle_rkey_reg_resp Take the chance to fix the same issue in m3ua_rx_rkm_dereg_rsp. Change-Id: I0b15d81099a9f8274b7e39962caa339da644e0dc
2018-08-13sscp_scrc: Fix memleak of xua_msg when handing it to scrc_rx_mtp_xfer_ind_xuaPau Espin Pedrol1-4/+12
Fixes following error provided by LeakSanitizer: Indirect leak of 1496 byte(s) in 11 object(s) allocated from: #0 0x7f1eb3332d99 in __interceptor_malloc /build/gcc/src/gcc/libsanitizer/asan/asan_malloc_linux.cc:86 #1 0x7f1eae617b61 in _talloc_zero (/usr/lib/libtalloc.so.2+0x5b61) #2 0x7f1eb063e365 in xua_msg_alloc /home/pespin/dev/sysmocom/git/libosmo-sccp/src/xua_msg.c:49 #3 0x7f1eb0650ee3 in osmo_sccp_to_xua /home/pespin/dev/sysmocom/git/libosmo-sccp/src/sccp2sua.c:1298 #4 0x7f1eb0668d6a in mtp_user_prim_cb /home/pespin/dev/sysmocom/git/libosmo-sccp/src/sccp_user.c:173 #5 0x7f1eb068ba86 in deliver_to_mtp_user /home/pespin/dev/sysmocom/git/libosmo-sccp/src/osmo_ss7_hmrt.c:94 #6 0x7f1eb068bf00 in hmdt_message_for_distribution /home/pespin/dev/sysmocom/git/libosmo-sccp/src/osmo_ss7_hmrt.c:133 #7 0x7f1eb068d345 in m3ua_hmdc_rx_from_l2 /home/pespin/dev/sysmocom/git/libosmo-sccp/src/osmo_ss7_hmrt.c:275 #8 0x7f1eb063c08f in m3ua_rx_xfer /home/pespin/dev/sysmocom/git/libosmo-sccp/src/m3ua.c:586 #9 0x7f1eb063cea6 in m3ua_rx_msg /home/pespin/dev/sysmocom/git/libosmo-sccp/src/m3ua.c:739 #10 0x7f1eb0687188 in xua_cli_read_cb /home/pespin/dev/sysmocom/git/libosmo-sccp/src/osmo_ss7.c:1590 #11 0x7f1eaff77db4 in osmo_stream_cli_read /home/pespin/dev/sysmocom/git/libosmo-netif/src/stream.c:192 #12 0x7f1eaff79091 in osmo_stream_cli_fd_cb /home/pespin/dev/sysmocom/git/libosmo-netif/src/stream.c:276 #13 0x7f1eaf259795 in osmo_fd_disp_fds /home/pespin/dev/sysmocom/git/libosmocore/src/select.c:217 #14 0x7f1eaf259abb in osmo_select_main /home/pespin/dev/sysmocom/git/libosmocore/src/select.c:257 #15 0x55666c1bebd3 in main /home/pespin/dev/sysmocom/git/osmo-msc/src/osmo-msc/msc_main.c:697 #16 0x7f1ead1c306a in __libc_start_main (/usr/lib/libc.so.6+0x2306a) #17 0x55666c1bc649 in _start (/home/pespin/dev/sysmocom/build/new/out/bin/osmo-msc+0x185649) The code path is the following, starting from mpt_user_prim_cb: mtp_user_prim_cb osmo_sccp_to_xua xua_msg_alloc scrc_rx_mtp_xfer_ind_xua sccp_scoc_rx_from_scrc scrc_node_6 scrc_node_4 scrc_translate_node_9 So the xua_msg is created in mtp_user_prim_cb through osmo_sccp_to_xua and then handed over to scrc_rx_mtp_xfer_ind_xua which transfers the xua_msg and thus should take ownserhip of it, and consecuently freeing it once it's done using it. Change-Id: I43e159c82b64bd85b185f77ee19b6455a96e082f
2018-08-06debian/rules: Don't overwrite .tarball-versionHarald Welte1-4/+0
The .tarball-version file should contain the *source version* uniquely identifying the git commit, and not the Debian package name. With https://gerrit.osmocom.org/#/c/osmo-ci/+/10343/ there is a correct .tarball-version file in the .tar.xz of the nightly source packages. Change-Id: I620c96eb311be6fdd4187bdcc311ea893ad93614 Related: OS#3449
2018-08-01Migrate from ipa_ccm_idtag_parse() to ipa_ccm_id_resp_parse()Harald Welte1-1/+1
In libosmocore Change-ID I1834d90fbcdbfcb05f5b8cfe39bfe9543737ef8f we have introduced ipa_ccm_id_resp_parse() as a bugfixed replacement of ipa_ccm_idtag_parse(). The main difference is that the returned "value" parts now have a correct reported "length", whereas before this commit they all reported a one-byte too-long "length" for each IE. Change-Id: I3c79d3bb56cc1370b9922e64d13d2d5508fd8039
2018-07-27Bump version: → Espin Pedrol4-7/+41
Change-Id: Ia087b9f03a73a08f0eaa461f61c6244aaf13e3d4
2018-07-24git-version-gen: Don't check for .git directoryDaniel Willmann1-2/+2
This check is not in all our repos that use git-version-gen. Indeed it seems to be a leftover of openbsc where I think it wanted to ensure being called in the openbsc subfolder or something? libosmocore e.g. doesn't have it. In any case .git being a directory is not always true (if using git worktree) so remove this check. Change-Id: Ic14561f3b041bb94d1b60e477b18e37077ce4c32
2018-07-20remove unused -p option from getopt() call in sccp_demo_userStefan Sperling1-1/+1
Change-Id: I31f30d8c855cb5faf3173987bfe5b36f5a585d02 Depends: I7432e6fc2617e0fd77a098fcd7d14abc40db7229
2018-07-20sccp_demo_user: use point code 23 for server and 1 for clientStefan Sperling1-19/+48
Fix previous commit 4dc9088cabedc40cb9072814237ad5926b12bd35 which broke this by using -1 for local and 23 for remote PC, for both server and client. Change-Id: I7432e6fc2617e0fd77a098fcd7d14abc40db7229 Related: OS#2666
2018-07-18comment: explain xua_msg free in m3ua_rx_xfer()Neels Hofmeyr1-0/+1
Change-Id: I6211c8809eefeb94289c4c497553561b043ee619
2018-07-12fix two memleaks in ipa_rx_msg_sccp()Neels Hofmeyr1-2/+5
1: Do not call xua_msg_alloc() which is later bluntly overwritten by m3ua_xfer_from_data(). 2: After dispatching to m3ua_hmdc_rx_from_l2(), call xua_msg_free(). Related: OS#3393 Change-Id: I0918f9bbc15b036619f1c25a133b69819b2a30fa