diff options
| author | Neels Hofmeyr <neels@hofmeyr.de> | 2022-07-23 13:44:15 +0200 |
|---|---|---|
| committer | Neels Hofmeyr <neels@hofmeyr.de> | 2022-07-23 16:15:57 +0200 |
| commit | 6dc91a44116ade41bb2e57769499384677bbd9e5 (patch) | |
| tree | 46b22c8d6b453c8c8bd3320112b688dc61669614 /include/osmocom/pfcp/pfcp_endpoint.h | |
| parent | 4a2509c66976f7409f14dadba94c12e16788643f (diff) | |
clarify osmo_pfcp_msg alloc API
Looking at the osmo_pfcp_msg_alloc API with a bit of distance now, I
found that:
- it is confusing to have a single function for req and resp. A resp
may pass remote_addr as NULL, and a req may pass in_reply_to as NULL.
Make this much more obvious with separate req/resp functions.
- the osmo_pfcp_endpoint_tx() implicitly puts the local Node ID into
sent PFCP messages, so the local_node_id arg for msg alloc is
redundant. Drop that.
Refactor without backwards compat, because we have not yet officially
released this API. This requires a fixup patch to osmo-upf.git (and
affects unmerged patches to osmo-hnbgw.git).
Related: SYS#5599
Related: I73e6da3b80f05e9408c81f41ac05d6578b8e31cf (osmo-upf)
Change-Id: I0d71134e42932cc72992eba73a15e82bc7cd11bd
Diffstat (limited to 'include/osmocom/pfcp/pfcp_endpoint.h')
0 files changed, 0 insertions, 0 deletions