aboutsummaryrefslogtreecommitdiffstats
path: root/configure.ac
diff options
context:
space:
mode:
authorNeels Hofmeyr <neels@hofmeyr.de>2022-07-23 13:44:33 +0200
committerNeels Hofmeyr <neels@hofmeyr.de>2022-07-28 13:52:17 +0200
commit1a9a3ad342bcd558c8e06f238f91644116d45028 (patch)
treec1cb92e4e17465c4efe77606dac16e7b659f4431 /configure.ac
parent6dc91a44116ade41bb2e57769499384677bbd9e5 (diff)
apply code review: refactor pfcp_endpoint API
Code review requested that the API should use functions instead of direct access to a struct. I have moved all user provided config to a separate struct osmo_pfcp_endpoint_cfg, to be passed to osmo_pfcp_endpoint_create(). Halfway through those changes, I am not so certain whether that is what reviewers had in mind. It makes sense from the point of view to keep nr of arguments passed to osmo_pfcp_endpoint_create() small, and to allow changing the user provided config without requiring a new osmo_pfcp_endpoint_create2() API function. Though that again has ABI compat problems, and makes no sense from the point of view that all access should be done via API functions. Personally I don't really agree with this change, which is probably the reason why this patch ended up this way. Related: SYS#5599 Change-Id: If80c35c6a942bf9593781b5a6bc28ba37323ce5e
Diffstat (limited to 'configure.ac')
0 files changed, 0 insertions, 0 deletions