aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHarald Welte <laforge@osmocom.org>2022-11-03 11:26:14 +0100
committerHarald Welte <laforge@osmocom.org>2022-11-03 12:42:57 +0100
commitc9b46a1c34a6c3efe6882891df7282b37fe52a12 (patch)
tree92b8ac9c14183e2fbe852903a7ad2284e8f49eae
parent2404c9ae2af03154e95789ac2ffe7f029d2cdcbf (diff)
Support building with -Werror=strict-prototypes / -Werror=old-style-definition
Unfortunately "-std=c99" is not sufficient to make gcc ignore code that uses constructs of earlier C standards, which were abandoned in C99. See https://lwn.net/ml/fedora-devel/Y1kvF35WozzGBpc8@redhat.com/ for some related discussion. Change-Id: I79c51b78d1b055361f9ef5434361847353791d0d
-rw-r--r--src/libosmo-gtlv/gtlv_gen.c10
-rw-r--r--tests/libosmo-gtlv/gtlv_dec_enc_test.c2
-rw-r--r--tests/libosmo-gtlv/gtlv_test.c10
-rw-r--r--tests/libosmo-gtlv/test_gtlv_gen/gtlv_gen_test.c2
-rw-r--r--tests/libosmo-gtlv/test_tliv/tliv_test.c2
-rw-r--r--tests/libosmo-pfcp/pfcp_test.c4
6 files changed, 15 insertions, 15 deletions
diff --git a/src/libosmo-gtlv/gtlv_gen.c b/src/libosmo-gtlv/gtlv_gen.c
index e374ea9..d3d407f 100644
--- a/src/libosmo-gtlv/gtlv_gen.c
+++ b/src/libosmo-gtlv/gtlv_gen.c
@@ -62,7 +62,7 @@ static bool seen(const char *str, const void *from_def)
llist_add(&s->entry, &seen_list);
return false;
}
-static void clear_seen()
+static void clear_seen(void)
{
struct seen_entry *s;
while ((s = llist_first_entry_or_null(&seen_list, struct seen_entry, entry))) {
@@ -148,7 +148,7 @@ static void write_ie_auto_structs(const struct osmo_gtlv_gen_ie_o ies[])
/* Write all auto-generated structs, starting with the outer message definitions and nesting into all contained IE
* definitions. */
-static void write_auto_structs()
+static void write_auto_structs(void)
{
const struct osmo_gtlv_gen_msg *gen_msg;
clear_seen();
@@ -171,7 +171,7 @@ static void write_auto_structs()
* myproto_msg_goo goo;
* };
*/
-static void write_msg_union()
+static void write_msg_union(void)
{
const struct osmo_gtlv_gen_msg *gen_msg;
for (gen_msg = g_cfg->msg_defs; gen_msg->name; gen_msg++) {
@@ -193,7 +193,7 @@ static void write_msg_union()
}
/* Write the C header, myproto_ies_auto.h */
-static void write_h()
+static void write_h(void)
{
printf("/* THIS FILE IS GENERATED FROM %s */\n", __FILE__);
printf("#include <stdint.h>\n");
@@ -326,7 +326,7 @@ static void write_nested_ies_array(const struct osmo_gtlv_gen_ie_o *ies)
/* Write the bulk of the C code: on the basis of the list of messages (g_cfg->msg_defs), write all dec/enc function
* declarations, all IEs arrays as well as the list of message types, first triggering to write the C code for any inner
* layers. */
-static void write_c()
+static void write_c(void)
{
const struct osmo_gtlv_gen_msg *gen_msg;
diff --git a/tests/libosmo-gtlv/gtlv_dec_enc_test.c b/tests/libosmo-gtlv/gtlv_dec_enc_test.c
index 848c0ef..fe72a10 100644
--- a/tests/libosmo-gtlv/gtlv_dec_enc_test.c
+++ b/tests/libosmo-gtlv/gtlv_dec_enc_test.c
@@ -543,7 +543,7 @@ void test_enc_dec(const char *label, const struct osmo_gtlv_cfg *cfg, const stru
}
}
-int main()
+int main(int argc, char **argv)
{
ctx = talloc_named_const(NULL, 0, "gtlv_test");
msgb_talloc_ctx_init(ctx, 0);
diff --git a/tests/libosmo-gtlv/gtlv_test.c b/tests/libosmo-gtlv/gtlv_test.c
index 8023699..8711063 100644
--- a/tests/libosmo-gtlv/gtlv_test.c
+++ b/tests/libosmo-gtlv/gtlv_test.c
@@ -329,7 +329,7 @@ struct ie *t8l8v_tests[] = {
t8l8v_test_multi,
};
-void test_t8l8v()
+void test_t8l8v(void)
{
test_tlv(__func__, t8l8v_tests, ARRAY_SIZE(t8l8v_tests), &osmo_t8l8v_cfg);
}
@@ -378,7 +378,7 @@ struct ie *t16l16v_tests[] = {
t16l16v_test_multi,
};
-void test_t16l16v()
+void test_t16l16v(void)
{
test_tlv(__func__, t16l16v_tests, ARRAY_SIZE(t16l16v_tests), &osmo_t16l16v_cfg);
}
@@ -521,7 +521,7 @@ const struct osmo_gtlv_cfg txlxv_cfg = {
.store_tl = txlxv_store_tl,
};
-void test_txlxv()
+void test_txlxv(void)
{
test_tlv(__func__, txlxv_tests, ARRAY_SIZE(txlxv_tests), &txlxv_cfg);
}
@@ -609,12 +609,12 @@ struct ie *tliv_tests[] = {
tliv_test1,
};
-void test_tliv()
+void test_tliv(void)
{
test_tlv(__func__, tliv_tests, ARRAY_SIZE(tliv_tests), &osmo_tliv_cfg);
}
-int main()
+int main(int argc, char **argv)
{
ctx = talloc_named_const(NULL, 0, "gtlv_test");
msgb_talloc_ctx_init(ctx, 0);
diff --git a/tests/libosmo-gtlv/test_gtlv_gen/gtlv_gen_test.c b/tests/libosmo-gtlv/test_gtlv_gen/gtlv_gen_test.c
index 1997fdc..411b802 100644
--- a/tests/libosmo-gtlv/test_gtlv_gen/gtlv_gen_test.c
+++ b/tests/libosmo-gtlv/test_gtlv_gen/gtlv_gen_test.c
@@ -245,7 +245,7 @@ void test_enc_dec(const char *label, const struct osmo_gtlv_cfg *cfg, bool order
}
}
-int main()
+int main(int argc, char **argv)
{
ctx = talloc_named_const(NULL, 0, "test_gen_tlv");
msgb_talloc_ctx_init(ctx, 0);
diff --git a/tests/libosmo-gtlv/test_tliv/tliv_test.c b/tests/libosmo-gtlv/test_tliv/tliv_test.c
index 49ae25c..242fb1a 100644
--- a/tests/libosmo-gtlv/test_tliv/tliv_test.c
+++ b/tests/libosmo-gtlv/test_tliv/tliv_test.c
@@ -204,7 +204,7 @@ const struct osmo_gtlv_cfg osmo_tliv_cfg = {
.store_tl = tliv_store_tl,
};
-int main()
+int main(int argc, char **argv)
{
ctx = talloc_named_const(NULL, 0, "test_gen_tlv");
msgb_talloc_ctx_init(ctx, 0);
diff --git a/tests/libosmo-pfcp/pfcp_test.c b/tests/libosmo-pfcp/pfcp_test.c
index 189622e..b0f3a50 100644
--- a/tests/libosmo-pfcp/pfcp_test.c
+++ b/tests/libosmo-pfcp/pfcp_test.c
@@ -451,7 +451,7 @@ struct osmo_pfcp_msg tests[] = {
},
};
-void test_enc_dec()
+void test_enc_dec(void)
{
int i;
for (i = 0; i < ARRAY_SIZE(tests); i++) {
@@ -500,7 +500,7 @@ void test_enc_dec()
}
}
-int main()
+int main(int argc, char **argv)
{
ctx = talloc_named_const(NULL, 0, "pfcp_test");
msgb_talloc_ctx_init(ctx, 0);