erlang
/
osmo_ss7
mirror of https://gerrit.osmocom.org/erlang/osmo_ss7
4
0
Fork 0
Code Issues Projects Releases Wiki Activity

Compare commits

base: erlang:cdea50ba6fab9f059bbafd40b82fc49a669b4858
Branches Tags
erlang:master
erlang:lynxis/epdg
...
compare: erlang:ae555f46408629eaf9edf14b9d64d351f0fc4cd5
Branches Tags
erlang:master
erlang:lynxis/epdg

8 Commits
cdea50ba6f ... ae555f4640

Author SHA1 Message Date
Gerrit User 1000074 ae555f4640 Update patch set 3 
Change has been successfully merged

Patch-set: 3
Status: merged
Tag: autogenerated:gerrit:merged
Reviewer: Gerrit User 1000074 <1000074@035e6965-6537-41bd-912c-053f3cf69326>
Label: SUBM=+1, ae27d7efa1f5cb5bb5e8ddab7c20b40e1616117d
Submission-id: 36095
Submitted-with: OK
Submitted-with: Rule-Name: gerrit~DefaultSubmitRule
Submitted-with: OK: Code-Review: Gerrit User 1000010 <1000010@035e6965-6537-41bd-912c-053f3cf69326>
Submitted-with: OK: Verified: Gerrit User 1000002 <1000002@035e6965-6537-41bd-912c-053f3cf69326>
Attention: {"person_ident":"Gerrit User 1000004 \u003c1000004@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"Change was submitted"}
Attention: {"person_ident":"Gerrit User 1000074 \u003c1000074@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"Change was submitted"}
Attention: {"person_ident":"Gerrit User 1000015 \u003c1000015@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"Change was submitted"}
 2024-02-28 17:45:43 +00:00
Gerrit User 1000010 f524f11f2c Update patch set 3 
Patch Set 3: Code-Review+2

Patch-set: 3
Reviewer: Gerrit User 1000010 <1000010@035e6965-6537-41bd-912c-053f3cf69326>
Label: Code-Review=+2, 1cce07f752c41628761b4dd53601e5b45c5d2194
Attention: {"person_ident":"Gerrit User 1000010 \u003c1000010@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"removed on reply"}
Attention: {"person_ident":"Gerrit User 1000074 \u003c1000074@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"Someone else replied on the change"}
 2024-02-28 17:39:27 +00:00
Gerrit User 1000002 03331fec8d Update patch set 3 
Patch Set 3: Verified+1

2 passed:
* [build] https://jenkins.osmocom.org/jenkins/job/gerrit-osmo_ss7-build/a1=default,a2=default,a3=default,a4=default,label=osmocom-gerrit/6/consoleFull
* [lint] https://jenkins.osmocom.org/jenkins/job/gerrit-lint/14716/consoleFull

Build Successful

Patch-set: 3
Tag: jenkins
Reviewer: Gerrit User 1000002 <1000002@035e6965-6537-41bd-912c-053f3cf69326>
Label: Verified=+1, cefeddaa79cf67bb8ea81e35f07bd5a9ac99a2ef
 2024-02-28 17:39:01 +00:00
Gerrit User 1000074 6ada250af6 Update patch set 3 
Patch Set 3:

(1 comment)

Patch-set: 3
Attention: {"person_ident":"Gerrit User 1000074 \u003c1000074@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1000074\u003e replied on the change"}
 2024-02-28 17:38:54 +00:00
Gerrit User 1000002 2e166cf72d Update patch set 3 
Patch Set 3:

Build Started
https://jenkins.osmocom.org/jenkins/job/gerrit-osmo_ss7/6/consoleFull

Patch-set: 3
Tag: jenkins
 2024-02-28 17:38:46 +00:00
Gerrit User 1000074 f29603fe52 Create patch set 3 
Uploaded patch set 3.

Outdated Votes:
* Code-Review+1 (copy condition: "changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN")
* Verified+1 (copy condition: "changekind:NO_CHANGE OR changekind:NO_CODE_CHANGE")


Patch-set: 3
Subject: ipa_proto.erl: Implement TCP/IPA reassembly
Commit: 2286c1b873
Tag: autogenerated:gerrit:newPatchSet
Groups: 2286c1b873
Attention: {"person_ident":"Gerrit User 1000004 \u003c1000004@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"Vote got outdated and was removed: Code-Review+1"}
Attention: {"person_ident":"Gerrit User 1000010 \u003c1000010@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"Vote got outdated and was removed: Code-Review+1"}
 2024-02-28 17:38:27 +00:00
Gerrit User 1000010 26ce651233 Update patch set 2 
Patch Set 2: Code-Review+1

(2 comments)

Patch-set: 2
Reviewer: Gerrit User 1000010 <1000010@035e6965-6537-41bd-912c-053f3cf69326>
Label: Code-Review=+1, 53eb1bed089cbcd20cfe58801226a96be91e4bfe
Attention: {"person_ident":"Gerrit User 1000010 \u003c1000010@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1000010\u003e replied on the change"}
 2024-02-28 17:24:12 +00:00
Gerrit User 1000004 b66838008e Update patch set 2 
Patch Set 2: Code-Review+1

Patch-set: 2
Reviewer: Gerrit User 1000004 <1000004@035e6965-6537-41bd-912c-053f3cf69326>
Label: Code-Review=+1, f81144bf156d8b44e58b5a71e53b1ec6d4b073fe
Attention: {"person_ident":"Gerrit User 1000004 \u003c1000004@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1000004\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1000074 \u003c1000074@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000004\u003e replied on the change"}
 2024-02-28 17:00:42 +00:00
2 changed files with 60 additions and 0 deletions
Show Stats Expand all files Collapse all files

4
2286c1b8738d715950026650bf53f19a69d6ed0e Normal file
View File

@ -0,0 +1,4 @@
{
"comments": [],
"submitRequirementResults": []
}

56
eef65b5b2ccaaeb2b2cf4b408889e892e5d92827 Normal file
View File

@ -0,0 +1,56 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "f2852495_6fd38ab6",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 2
},
"lineNbr": 0,
"author": {
"id": 1000010
},
"writtenOn": "2024-02-28T17:24:12Z",
"side": 1,
"message": "Would be nice to have some unit test coverage for this. Not blocking though.",
"revId": "eef65b5b2ccaaeb2b2cf4b408889e892e5d92827",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "de67f94a_5f9237c5",
"filename": "src/ipa_proto.erl",
"patchSetId": 2
},
"lineNbr": 189,
"author": {
"id": 1000010
},
"writtenOn": "2024-02-28T17:24:12Z",
"side": 1,
"message": "cosmetic: please fix formatting here (nesting inside `case-of`)",
"revId": "eef65b5b2ccaaeb2b2cf4b408889e892e5d92827",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "93e208e1_fa289560",
"filename": "src/ipa_proto.erl",
"patchSetId": 2
},
"lineNbr": 189,
"author": {
"id": 1000074
},
"writtenOn": "2024-02-28T17:38:54Z",
"side": 1,
"message": "Done",
"parentUuid": "de67f94a_5f9237c5",
"revId": "eef65b5b2ccaaeb2b2cf4b408889e892e5d92827",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}