path: root/net
diff options
authorPavel Emelyanov <xemul@openvz.org>2011-02-04 13:02:36 -0800
committerDavid S. Miller <davem@davemloft.net>2011-02-04 13:02:36 -0800
commit1158f762e57c1cdcda631c1c5f339e4853caa82b (patch)
treec4e0fa76daa3c8f37312d4de6a3fd587545e920e /net
parentf60ac8e7ab7cbb413a0131d5665b053f9f386526 (diff)
bridge: Don't put partly initialized fdb into hash
The fdb_create() puts a new fdb into hash with only addr set. This is not good, since there are callers, that search the hash w/o the lock and access all the other its fields. Applies to current netdev tree. Signed-off-by: Pavel Emelyanov <xemul@openvz.org> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
1 files changed, 2 insertions, 2 deletions
diff --git a/net/bridge/br_fdb.c b/net/bridge/br_fdb.c
index 2872393b293..88485cc74dc 100644
--- a/net/bridge/br_fdb.c
+++ b/net/bridge/br_fdb.c
@@ -328,12 +328,12 @@ static struct net_bridge_fdb_entry *fdb_create(struct hlist_head *head,
fdb = kmem_cache_alloc(br_fdb_cache, GFP_ATOMIC);
if (fdb) {
memcpy(fdb->addr.addr, addr, ETH_ALEN);
- hlist_add_head_rcu(&fdb->hlist, head);
fdb->dst = source;
fdb->is_local = is_local;
fdb->is_static = is_local;
fdb->ageing_timer = jiffies;
+ hlist_add_head_rcu(&fdb->hlist, head);
return fdb;