path: root/fs/ubifs/replay.c
diff options
authorArtem Bityutskiy <Artem.Bityutskiy@nokia.com>2011-05-13 16:02:19 +0300
committerArtem Bityutskiy <Artem.Bityutskiy@nokia.com>2011-05-16 10:31:40 +0300
commit7703f09ded1b8719d2defe0f61215b4a08702ffa (patch)
tree4783cecf73b55e4a402e227fd5ef43a669806c44 /fs/ubifs/replay.c
parente9ef7b5f25d31c5660fb4a87f4b40ac48070fcb7 (diff)
UBIFS: double check that buds are replied in order
Commit 52c6e6f990669deac3f370f1603815adb55a1dbd provides misleading infomation in the commit messages - buds are replied in order. And the real reason why that fix helped is probably because it made sure we seek head even in read-only mode (so deferred recovery will have seeked heads). This patch adds an assertion which will fire if we reply buds out of order. Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Diffstat (limited to 'fs/ubifs/replay.c')
1 files changed, 4 insertions, 0 deletions
diff --git a/fs/ubifs/replay.c b/fs/ubifs/replay.c
index e27346f6c67..5e815034aab 100644
--- a/fs/ubifs/replay.c
+++ b/fs/ubifs/replay.c
@@ -713,6 +713,7 @@ static int replay_buds(struct ubifs_info *c)
struct bud_entry *b;
int err, uninitialized_var(free), uninitialized_var(dirty);
+ unsigned long long prev_sqnum = 0;
list_for_each_entry(b, &c->replay_buds, list) {
err = replay_bud(c, b->bud->lnum, b->bud->start, b->bud->jhead,
@@ -723,6 +724,9 @@ static int replay_buds(struct ubifs_info *c)
free, dirty, b->bud->jhead);
if (err)
return err;
+ ubifs_assert(b->sqnum > prev_sqnum);
+ prev_sqnum = b->sqnum;
return 0;