path: root/fs/ext4/ialloc.c
diff options
authorJan Kara <jack@suse.cz>2011-12-18 17:37:02 -0500
committerTheodore Ts'o <tytso@mit.edu>2011-12-18 17:37:02 -0500
commitacd6ad83517639e8f09a8c5525b1dccd81cd2a10 (patch)
treecdfa0a3cc0c65ce27f9e41a5080e9cfc78776b7f /fs/ext4/ialloc.c
parent5635a62b83c04d05e4eb4575a1c3de51a35bacdc (diff)
ext4: fix error handling on inode bitmap corruption
When insert_inode_locked() fails in ext4_new_inode() it most likely means inode bitmap got corrupted and we allocated again inode which is already in use. Also doing unlock_new_inode() during error recovery is wrong since the inode does not have I_NEW set. Fix the problem by jumping to fail: (instead of fail_drop:) which declares filesystem error and does not call unlock_new_inode(). Signed-off-by: Jan Kara <jack@suse.cz> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Diffstat (limited to 'fs/ext4/ialloc.c')
1 files changed, 6 insertions, 2 deletions
diff --git a/fs/ext4/ialloc.c b/fs/ext4/ialloc.c
index 00beb4f9cc4..8fb6844f973 100644
--- a/fs/ext4/ialloc.c
+++ b/fs/ext4/ialloc.c
@@ -885,8 +885,12 @@ got:
if (IS_DIRSYNC(inode))
if (insert_inode_locked(inode) < 0) {
- err = -EINVAL;
- goto fail_drop;
+ /*
+ * Likely a bitmap corruption causing inode to be allocated
+ * twice.
+ */
+ err = -EIO;
+ goto fail;
inode->i_generation = sbi->s_next_generation++;