From f625e0fd513fa12cfabec9ed19f71a9bd7dd60e1 Mon Sep 17 00:00:00 2001 From: Guenter Roeck Date: Sat, 2 Jun 2012 11:35:53 -0700 Subject: [PATCH] hwmon: (tmp421) Convert to use devm_ functions Convert to use devm_ functions to reduce code size and simplify the code. Signed-off-by: Guenter Roeck Acked-by: Jean Delvare --- drivers/hwmon/tmp421.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/hwmon/tmp421.c b/drivers/hwmon/tmp421.c index 8fac87a3854..6a8ded29f1e 100644 --- a/drivers/hwmon/tmp421.c +++ b/drivers/hwmon/tmp421.c @@ -267,7 +267,8 @@ static int tmp421_probe(struct i2c_client *client, struct tmp421_data *data; int err; - data = kzalloc(sizeof(struct tmp421_data), GFP_KERNEL); + data = devm_kzalloc(&client->dev, sizeof(struct tmp421_data), + GFP_KERNEL); if (!data) return -ENOMEM; @@ -277,11 +278,11 @@ static int tmp421_probe(struct i2c_client *client, err = tmp421_init_client(client); if (err) - goto exit_free; + return err; err = sysfs_create_group(&client->dev.kobj, &tmp421_group); if (err) - goto exit_free; + return err; data->hwmon_dev = hwmon_device_register(&client->dev); if (IS_ERR(data->hwmon_dev)) { @@ -293,10 +294,6 @@ static int tmp421_probe(struct i2c_client *client, exit_remove: sysfs_remove_group(&client->dev.kobj, &tmp421_group); - -exit_free: - kfree(data); - return err; } @@ -307,8 +304,6 @@ static int tmp421_remove(struct i2c_client *client) hwmon_device_unregister(data->hwmon_dev); sysfs_remove_group(&client->dev.kobj, &tmp421_group); - kfree(data); - return 0; }